From 2d9afb9b395ea0cc71432613e0df104aefcf24c1 Mon Sep 17 00:00:00 2001 From: Nathan Lilienthal Date: Wed, 2 Jan 2019 16:56:36 -0500 Subject: [PATCH] Process Mouse Binding Actions Earlier To allow for a mouse binding to properly copy text, we should process the mouse binding actions before thee built-in functionality, which will clear the selection on right click, for example. --- CHANGELOG.md | 1 + src/input.rs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index de808894..6a1d152b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Alt modifier is no longer sent separately from the modified key - Various Windows issues, like color support and performance, through the new ConPTY - Fixed rendering non default mouse cursors in terminal mouse mode (linux) +- Fix the `Copy` `mouse_bindings` action ([#1963](https://github.com/jwilm/alacritty/issues/1963)) ## Version 0.2.4 diff --git a/src/input.rs b/src/input.rs index 23ccdd58..a4deed04 100644 --- a/src/input.rs +++ b/src/input.rs @@ -646,6 +646,8 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> { MouseButton::Other(_) => None, }; + self.process_mouse_bindings(modifiers, button); + if let Some(prev_state) = prev_state { if prev_state != state { match state { @@ -658,8 +660,6 @@ impl<'a, A: ActionContext + 'a> Processor<'a, A> { if let ElementState::Released = state { return; } - - self.process_mouse_bindings(modifiers, button); } /// Process key input