1
0
Fork 0
mirror of https://github.com/alacritty/alacritty.git synced 2024-11-11 13:51:01 -05:00

Fix scrollback live reloading

This fixes two issues with live reloading the `scrolling.history`
property.

It is now possible to increase the scrollback history without restarting
Alacritty.

When decreasing the scrollback history while scrolled beyond the new
history limit, Alacritty will reset the viewport position to the new
limit instead of crashing.

This fixes #2147.
This commit is contained in:
Christian Duerr 2019-03-02 18:32:48 +00:00 committed by GitHub
parent e0fdc3329c
commit 3c4bb7c115
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 0 deletions

View file

@ -14,6 +14,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix panic which could occur when quitting Alacritty on Windows if using the Conpty backend - Fix panic which could occur when quitting Alacritty on Windows if using the Conpty backend
- Automatic copying of selection to clipboard when mouse is released outside of Alacritty - Automatic copying of selection to clipboard when mouse is released outside of Alacritty
- Scrollback history live reload only working when shrinking lines
- Crash when decreasing scrollback history in config while scrolled in history
## Version 0.2.9 ## Version 0.2.9

View file

@ -163,7 +163,9 @@ impl<T: Copy + Clone> Grid<T> {
pub fn update_history(&mut self, history_size: usize, template: &T) pub fn update_history(&mut self, history_size: usize, template: &T)
{ {
self.raw.update_history(history_size, Row::new(self.cols, &template)); self.raw.update_history(history_size, Row::new(self.cols, &template));
self.max_scroll_limit = history_size;
self.scroll_limit = min(self.scroll_limit, history_size); self.scroll_limit = min(self.scroll_limit, history_size);
self.display_offset = min(self.display_offset, self.scroll_limit);
} }
pub fn scroll_display(&mut self, scroll: Scroll) { pub fn scroll_display(&mut self, scroll: Scroll) {