From 5e22512fe6a1a6a8e347c09bbc486408753bff95 Mon Sep 17 00:00:00 2001 From: Kirill Chibisov Date: Tue, 21 Jan 2020 00:13:39 +0300 Subject: [PATCH] Disable drawing bold text bright by default Since the assumption is usually that bold text is drawn in bright colors, this might break some applications. However some other terminals have already taken this leap, which should lessen the impact for Alacritty. Since this might still be desired and necessary for certain applications, the config option is just switched to draw with normal colors by default, however the old behavior can still be restored. Fixes #2779. --- CHANGELOG.md | 1 + alacritty.yml | 2 +- alacritty_terminal/src/config/mod.rs | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6d056778..8c56c1c2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Renamed `WINIT_HIDPI_FACTOR` environment variable to `WINIT_X11_SCALE_FACTOR` - Print an error instead of crashing, when startup working directory is invalid - Line selection will now expand across wrapped lines +- The default value for `draw_bold_text_with_bright_colors` is now `false` ### Fixed diff --git a/alacritty.yml b/alacritty.yml index ab176bdd..e60a499e 100644 --- a/alacritty.yml +++ b/alacritty.yml @@ -177,7 +177,7 @@ #use_thin_strokes: true # If `true`, bold text is drawn using the bright color variants. -#draw_bold_text_with_bright_colors: true +#draw_bold_text_with_bright_colors: false # Colors (Tomorrow Night Bright) #colors: diff --git a/alacritty_terminal/src/config/mod.rs b/alacritty_terminal/src/config/mod.rs index d077190b..fd049af0 100644 --- a/alacritty_terminal/src/config/mod.rs +++ b/alacritty_terminal/src/config/mod.rs @@ -60,7 +60,7 @@ pub struct Config { /// Should draw bold text with brighter colors instead of bold font #[serde(default, deserialize_with = "failure_default")] - draw_bold_text_with_bright_colors: DefaultTrueBool, + draw_bold_text_with_bright_colors: bool, #[serde(default, deserialize_with = "failure_default")] pub colors: Colors, @@ -149,7 +149,7 @@ impl Config { #[inline] pub fn draw_bold_text_with_bright_colors(&self) -> bool { - self.draw_bold_text_with_bright_colors.0 + self.draw_bold_text_with_bright_colors } /// Should show render timer