1
0
Fork 0
mirror of https://github.com/alacritty/alacritty.git synced 2024-11-18 13:55:23 -05:00

Fix inconsitent cursor position when scrolling

This commit fixes regression introduced in cfc20d4f34.
`self.cursor.line` forced the cursor to hold a fixed location while scrolling
until its "original" location (usually the shell prompt) went off the screen.
So cursor position should be keep updated, which can be achieved by using
`self.inner.line()`.

Fixes #2570.
This commit is contained in:
Kirill Chibisov 2019-06-22 02:00:01 +03:00 committed by Christian Duerr
parent 6013d1ec3e
commit 72088dafec
2 changed files with 5 additions and 1 deletions

View file

@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed
- GUI programs launched by Alacritty starting in the background on X11
- Text Cursor position when scrolling
## 0.3.3

View file

@ -436,7 +436,10 @@ impl<'a> Iterator for RenderableCellsIter<'a> {
let cell = Indexed {
inner: self.grid[self.cursor],
column: self.cursor.col,
line: self.cursor.line,
// Using `self.cursor.line` leads to inconsitent cursor position when
// scrolling. See https://github.com/jwilm/alacritty/issues/2570 for more
// info.
line: self.inner.line(),
};
let mut renderable_cell =