1
0
Fork 0
mirror of https://github.com/alacritty/alacritty.git synced 2024-11-11 13:51:01 -05:00

Fix the estimated DPR to 1 on Wayland.

On Wayland, regardless of the underlying scale factor for an output, The
scale factor is 1.0 until we receive the first DPRChanged event. To
correctly calculate the window sizes, we must use a DPR of 1.0 as well.

Ideally we would know what the DPR of the window we're being opened in
is going to be, and avoid the estimation guessing game, but that doesn't
seem possible with the current interfaces provided by the window
systems.
This commit is contained in:
Nathan Lilienthal 2021-02-01 16:25:24 -05:00
parent 73759da0f5
commit a5e2ccd5ab
2 changed files with 13 additions and 8 deletions

View file

@ -19,6 +19,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Crash due to assertion failure on 32-bit architectures - Crash due to assertion failure on 32-bit architectures
- Segmentation fault on shutdown with Wayland - Segmentation fault on shutdown with Wayland
- Incorrect estimated DPR with Wayland
### Removed ### Removed

View file

@ -188,9 +188,18 @@ pub struct Display {
impl Display { impl Display {
pub fn new<E>(config: &Config, event_loop: &EventLoop<E>) -> Result<Display, Error> { pub fn new<E>(config: &Config, event_loop: &EventLoop<E>) -> Result<Display, Error> {
// Guess DPR based on first monitor. #[cfg(any(not(feature = "x11"), target_os = "macos", windows))]
let estimated_dpr = let is_x11 = false;
event_loop.available_monitors().next().map(|m| m.scale_factor()).unwrap_or(1.); #[cfg(all(feature = "x11", not(any(target_os = "macos", windows))))]
let is_x11 = event_loop.is_x11();
// Guess DPR based on first monitor. On Wayland the initial frame always renders at a DPR
// of 1.
let estimated_dpr = if cfg!(any(target_os = "macos", windows)) || is_x11 {
event_loop.available_monitors().next().map(|m| m.scale_factor()).unwrap_or(1.)
} else {
1.
};
// Guess the target window dimensions. // Guess the target window dimensions.
let metrics = GlyphCache::static_metrics(config.ui_config.font.clone(), estimated_dpr)?; let metrics = GlyphCache::static_metrics(config.ui_config.font.clone(), estimated_dpr)?;
@ -278,11 +287,6 @@ impl Display {
#[cfg(target_os = "macos")] #[cfg(target_os = "macos")]
window.set_has_shadow(config.ui_config.background_opacity() >= 1.0); window.set_has_shadow(config.ui_config.background_opacity() >= 1.0);
#[cfg(all(feature = "x11", not(any(target_os = "macos", windows))))]
let is_x11 = event_loop.is_x11();
#[cfg(not(any(feature = "x11", target_os = "macos", windows)))]
let is_x11 = false;
// On Wayland we can safely ignore this call, since the window isn't visible until you // On Wayland we can safely ignore this call, since the window isn't visible until you
// actually draw something into it and commit those changes. // actually draw something into it and commit those changes.
#[cfg(not(any(target_os = "macos", windows)))] #[cfg(not(any(target_os = "macos", windows)))]