From b321406908a83f072594f8c2b455c3aefc121750 Mon Sep 17 00:00:00 2001 From: Elaina Martineau Date: Sun, 28 Apr 2019 10:09:26 -0600 Subject: [PATCH] Fix double-width characters in URLs only highlighting halfway --- CHANGELOG.md | 1 + alacritty_terminal/src/term/mod.rs | 9 +++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ba935720..d4182775 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed +- Double-width characters in URLs only being highlit on the left half - PTY size not getting updated when message bar is shown - Text Cursor disappearing - Incorrect positioning of zero-width characters over double-width characters diff --git a/alacritty_terminal/src/term/mod.rs b/alacritty_terminal/src/term/mod.rs index 94b2ade2..84a23eca 100644 --- a/alacritty_terminal/src/term/mod.rs +++ b/alacritty_terminal/src/term/mod.rs @@ -418,18 +418,15 @@ impl<'a> Iterator for RenderableCellsIter<'a> { let selected = self.selection.as_ref().map(|range| range.contains_(index)).unwrap_or(false); - // Skip empty cells - if cell.is_empty() && !selected { - continue; - } - // Underline URL highlights if self.url_highlight.as_ref().map(|range| range.contains_(index)).unwrap_or(false) { cell.inner.flags.insert(Flags::UNDERLINE); } - return Some(RenderableCell::new(self.config, self.colors, cell, selected)); + if !cell.is_empty() || selected { + return Some(RenderableCell::new(self.config, self.colors, cell, selected)); + } } } }