From b77b9b3bcdc457e4b2557e55f9983ce36e40a903 Mon Sep 17 00:00:00 2001 From: Kirill Chibisov Date: Fri, 30 Dec 2022 18:39:39 +0300 Subject: [PATCH] Fix crash when one dimension of the window is zero This fixes a crash on Windows when the user resizes the window to the point that it has the height of zero. The crash was introduced by the glutin update, since it requires non-zero sizes for the resize. --- alacritty/src/event.rs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/alacritty/src/event.rs b/alacritty/src/event.rs index 7cf77096..25d52e56 100644 --- a/alacritty/src/event.rs +++ b/alacritty/src/event.rs @@ -1176,11 +1176,10 @@ impl input::Processor> { match event { WindowEvent::CloseRequested => self.ctx.terminal.exit(), WindowEvent::Resized(size) => { - // Minimizing the window sends a Resize event with zero width and - // height. But there's no need to ever actually resize to this. - // ConPTY has issues when resizing down to zero size and back. - #[cfg(windows)] - if size.width == 0 && size.height == 0 { + // Ignore resize events to zero in any dimension, to avoid issues with Winit + // and the ConPTY. A 0x0 resize will also occur when the window is minimized + // on Windows. + if size.width == 0 || size.height == 0 { return; }