1
0
Fork 0
mirror of https://github.com/alacritty/alacritty.git synced 2024-11-03 04:34:21 -05:00

Run clippy on MSRV

Since not all suggested clippy lints by stable clippy are supported on
the MSRV of Alacritty, this commit moves the clippy checks to the MSRV.

Unfortunately this will mean that our lints might be significantly
behind, however it ensures our CI never blocks any code that should be
valid.

Developers themselves of course can still run the latest clippy to
follow the up to date recommendations.
This commit is contained in:
Christian Duerr 2021-02-27 15:06:22 +00:00 committed by GitHub
parent 72b341425d
commit edfcb81339
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 20 additions and 16 deletions

View file

@ -21,14 +21,15 @@ tasks:
- test: |
cd alacritty
cargo test
- oldstable: |
cd alacritty
rustup toolchain install --profile minimal 1.45.2
rustup default 1.45.2
cargo test
- clippy: |
cd alacritty
rustup component add clippy
cargo clippy --all-targets
- oldstable: |
cd alacritty
rustup toolchain install --profile minimal 1.43.1
cargo +1.43.1 test
- feature-wayland: |
cd alacritty/alacritty
cargo test --no-default-features --features=wayland

View file

@ -24,17 +24,18 @@ tasks:
cd alacritty
rustup toolchain install nightly -c rustfmt
cargo +nightly fmt -- --check
- oldstable: |
cd alacritty
rustup toolchain install --profile minimal 1.45.2
rustup default 1.45.2
cargo test
- clippy: |
cd alacritty
rustup component add clippy
cargo clippy --all-targets
- oldstable: |
cd alacritty
rustup toolchain install --profile minimal 1.43.1
cargo +1.43.1 test
- feature-wayland: |
cd alacritty/alacritty
cargo +1.43.1 test --no-default-features --features=wayland
cargo test --no-default-features --features=wayland
- feature-x11: |
cd alacritty/alacritty
cargo +1.43.1 test --no-default-features --features=x11
cargo test --no-default-features --features=x11

View file

@ -17,11 +17,11 @@ jobs:
- uses: actions/checkout@v2
- name: Stable
run: cargo test
- name: Oldstable
run: |
rustup default 1.45.2
cargo test
- name: Clippy
run: |
rustup component add clippy
cargo clippy --all-targets
- name: Oldstable
run: |
rustup default 1.43.1
cargo test

View file

@ -7,6 +7,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## 0.8.0-dev
### Packaging
- Minimum Rust version has been bumped to 1.45.0
### Added
- IME composition preview not appearing on Windows

2
Cargo.lock generated
View file

@ -1,7 +1,5 @@
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 3
[[package]]
name = "ab_glyph_rasterizer"
version = "0.1.4"