From fd7573d5d15ab229b233469fd9ab077158ece030 Mon Sep 17 00:00:00 2001 From: Kirill Chibisov Date: Tue, 11 Jan 2022 23:58:50 +0300 Subject: [PATCH] Don't blink when cursor is hidden This prevents unnecessary redraws when the terminal is idle, cursor is hidden and blinking is enabled. --- alacritty/src/event.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/alacritty/src/event.rs b/alacritty/src/event.rs index 24762dad..a29a101a 100644 --- a/alacritty/src/event.rs +++ b/alacritty/src/event.rs @@ -919,13 +919,15 @@ impl<'a, N: Notify + 'a, T: EventListener> ActionContext<'a, N, T> { fn update_cursor_blinking(&mut self) { // Get config cursor style. let mut cursor_style = self.config.terminal_config.cursor.style; - if self.terminal.mode().contains(TermMode::VI) { + let vi_mode = self.terminal.mode().contains(TermMode::VI); + if vi_mode { cursor_style = self.config.terminal_config.cursor.vi_mode_style.unwrap_or(cursor_style); - }; + } // Check terminal cursor style. let terminal_blinking = self.terminal.cursor_style().blinking; - let blinking = cursor_style.blinking_override().unwrap_or(terminal_blinking); + let mut blinking = cursor_style.blinking_override().unwrap_or(terminal_blinking); + blinking &= vi_mode || self.terminal().mode().contains(TermMode::SHOW_CURSOR); // Update cursor blinking state. let timer_id = TimerId::new(Topic::BlinkCursor, self.display.window.id());