From 2343e4bbd298b35ea5c190c52abd2b0cb9f79a18 Mon Sep 17 00:00:00 2001 From: Richard Grenville Date: Tue, 22 Sep 2015 08:34:28 +0800 Subject: [PATCH] Misc #308: Close config file after using it Misc #308: Close the config file after using it, instead of leaving it open forever. Thanks to SyedAmerGilani for the report. --- src/compton.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/src/compton.c b/src/compton.c index 92d08dc5..92935a3d 100644 --- a/src/compton.c +++ b/src/compton.c @@ -5466,12 +5466,17 @@ parse_config(session_t *ps, struct options_tmp *pcfgtmp) { } #endif - if (CONFIG_FALSE == config_read(&cfg, f)) { - printf("Error when reading configuration file \"%s\", line %d: %s\n", - path, config_error_line(&cfg), config_error_text(&cfg)); - config_destroy(&cfg); - free(path); - return; + { + int read_result = config_read(&cfg, f); + fclose(f); + f = NULL; + if (CONFIG_FALSE == read_result) { + printf("Error when reading configuration file \"%s\", line %d: %s\n", + path, config_error_line(&cfg), config_error_text(&cfg)); + config_destroy(&cfg); + free(path); + return; + } } config_set_auto_convert(&cfg, 1);