PolytreeDE
/
picom
mirror of https://github.com/yshui/picom.git
1
0
Fork 0
Code Releases Activity

Remove no-dock-shadow and no-dnd-shadow 

Deprecated since v4

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This commit is contained in:
Yuxuan Shui 2020-08-31 18:32:14 +01:00
parent 731bd61467
commit 283504d527
No known key found for this signature in database
GPG Key ID: 37C999F617EA1A47
3 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
man/picom.1.asciidoc
View File

@ -49,9 +49,6 @@ OPTIONS
*-c*, *--shadow*:: *-c*, *--shadow*::
Enabled client-side shadows on windows. Note desktop windows (windows with '_NET_WM_WINDOW_TYPE_DESKTOP') never get shadow, unless explicitly requested using the wintypes option. Enabled client-side shadows on windows. Note desktop windows (windows with '_NET_WM_WINDOW_TYPE_DESKTOP') never get shadow, unless explicitly requested using the wintypes option.
*-C*, *--no-dock-shadow*::
Avoid drawing shadows on dock/panel windows. This option is deprecated, you should use the *wintypes* option in your config file instead.
*-f*, *--fading*:: *-f*, *--fading*::
Fade windows in/out when opening/closing and when opacity changes, unless *--no-fading-openclose* is used. Fade windows in/out when opening/closing and when opacity changes, unless *--no-fading-openclose* is used.
@ -64,9 +61,6 @@ OPTIONS
*-e*, *--frame-opacity*='OPACITY':: *-e*, *--frame-opacity*='OPACITY'::
Opacity of window titlebars and borders. (0.1 - 1.0, disabled by default) Opacity of window titlebars and borders. (0.1 - 1.0, disabled by default)
*-G*, *--no-dnd-shadow*::
Don't draw shadows on drag-and-drop windows. This option is deprecated, you should use the *wintypes* option in your config file instead.
*-b*, *--daemon*:: *-b*, *--daemon*::
Daemonize process. Fork to background after initialization. Causes issues with certain (badly-written) drivers. Daemonize process. Fork to background after initialization. Causes issues with certain (badly-written) drivers.

14
src/config_libconfig.c
View File

@ -374,17 +374,15 @@ char *parse_config_libconfig(options_t *opt, const char *config_file, bool *shad
*shadow_enable = ival; *shadow_enable = ival;
// -C (no_dock_shadow) // -C (no_dock_shadow)
if (config_lookup_bool(&cfg, "no-dock-shadow", &ival)) { if (config_lookup_bool(&cfg, "no-dock-shadow", &ival)) {
log_warn("Option `no-dock-shadow` is deprecated, and will be removed." log_error("Option `no-dock-shadow` has been removed. Please use the "
" Please use the wintype option `shadow` of `dock` instead."); "wintype option `shadow` of `dock` instead.");
opt->wintype_option[WINTYPE_DOCK].shadow = false; goto err;
winopt_mask[WINTYPE_DOCK].shadow = true;
} }
// -G (no_dnd_shadow) // -G (no_dnd_shadow)
if (config_lookup_bool(&cfg, "no-dnd-shadow", &ival)) { if (config_lookup_bool(&cfg, "no-dnd-shadow", &ival)) {
log_warn("Option `no-dnd-shadow` is deprecated, and will be removed." log_error("Option `no-dnd-shadow` has been removed. Please use the "
" Please use the wintype option `shadow` of `dnd` instead."); "wintype option `shadow` of `dnd` instead.");
opt->wintype_option[WINTYPE_DND].shadow = false; goto err;
winopt_mask[WINTYPE_DND].shadow = true;
}; };
// -m (menu_opacity) // -m (menu_opacity)
if (config_lookup_float(&cfg, "menu-opacity", &dval)) { if (config_lookup_float(&cfg, "menu-opacity", &dval)) {

14
src/options.c
View File

@ -565,13 +565,13 @@ bool get_cfg(options_t *opt, int argc, char *const *argv, bool shadow_enable,
case 'O': opt->fade_out_step = normalize_d(atof(optarg)); break; case 'O': opt->fade_out_step = normalize_d(atof(optarg)); break;
case 'c': shadow_enable = true; break; case 'c': shadow_enable = true; break;
case 'C': case 'C':
winopt_mask[WINTYPE_DOCK].shadow = true; log_error("Option `--no-dock-shadow`/`-C` has been removed. Please"
opt->wintype_option[WINTYPE_DOCK].shadow = false; " use the wintype option `shadow` of `dock` instead.");
break; return false;
case 'G': case 'G':
winopt_mask[WINTYPE_DND].shadow = true; log_error("Option `--no-dnd-shadow`/`-G` has been removed. Please "
opt->wintype_option[WINTYPE_DND].shadow = false; "use the wintype option `shadow` of `dnd` instead.");
break; return false;
case 'm':; case 'm':;
double tmp; double tmp;
tmp = normalize_d(atof(optarg)); tmp = normalize_d(atof(optarg));
@ -604,7 +604,7 @@ bool get_cfg(options_t *opt, int argc, char *const *argv, bool shadow_enable,
case 'a': case 'a':
case 's': case 's':
log_error("-n, -a, and -s have been removed."); log_error("-n, -a, and -s have been removed.");
break; return false;
// Long options // Long options
case 256: case 256:
// --config // --config