PolytreeDE/picom
1
0
Fork 0
mirror of https://github.com/yshui/picom.git synced 2025-04-07 17:44:04 -04:00
Code Releases Activity

core: don't assert stale flags are not set in destroy_backend

Browse source 
And add a comment to explain why.

Closes #1091

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This commit is contained in:
Yuxuan Shui 2024-02-19 01:09:00 +00:00
parent 23e4c68069
commit 618cf64b23
No known key found for this signature in database
GPG key ID: D3A4405BE6CC17F4
1 changed files with 6 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/picom.c
View file

@ -628,15 +628,12 @@ static void destroy_backend(session_t *ps) {
// Unmapped windows could still have shadow images, but not pixmap
// images
assert(!w->win_image || w->state != WSTATE_UNMAPPED);
if (win_check_flags_any(w, WIN_FLAGS_PIXMAP_STALE) &&
w->state == WSTATE_MAPPED) {
log_warn("Stale flags set for mapped window %#010x "
"during backend destruction",
w->base.id);
assert(false);
}
// Unmapped windows can still have stale flags set, because their
// stale flags aren't handled until they are mapped.
// In some cases, the window might have PIXMAP_STALE flag set:
// 1. If the window is unmapped. Their stale flags won't be
// handled until they are mapped.
// 2. If we haven't had chance to handle the stale flags. This
// could happen if we received a root ConfigureNotify
// _immidiately_ after we redirected.
win_clear_flags(w, WIN_FLAGS_PIXMAP_STALE);
win_release_images(ps->backend_data, w);
}