PolytreeDE/picom
1
0
Fork 0
mirror of https://github.com/yshui/picom.git synced 2025-04-21 18:03:02 -04:00
Code Releases Activity

wm/win: remove an unused field of struct win

Browse source 
Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This commit is contained in:
Yuxuan Shui 2024-10-17 00:11:32 +01:00
parent 035d28a073
commit 8065c1fabe
No known key found for this signature in database
GPG key ID: D3A4405BE6CC17F4
3 changed files with 0 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/picom.c
View file

@ -794,7 +794,6 @@ static bool paint_preprocess(session_t *ps, bool *animation, struct win **out_bo
unredir_possible = true; unredir_possible = true;
} }
w->prev_trans = bottom;
bottom = w; bottom = w;
// If the screen is not redirected check if the window's unredir setting // If the screen is not redirected check if the window's unredir setting

18
src/wm/win.c
View file

@ -477,14 +477,6 @@ void win_process_image_flags(session_t *ps, struct win *w) {
return; return;
} }
if (!win_check_flags_any(w, WIN_FLAGS_PIXMAP_STALE) ||
win_check_flags_all(w, WIN_FLAGS_PIXMAP_ERROR) ||
// We don't need to do anything here for legacy backends
ps->backend_data == NULL) {
win_clear_flags(w, WIN_FLAGS_PIXMAP_STALE);
return;
}
// Image needs to be updated, update it. // Image needs to be updated, update it.
win_clear_flags(w, WIN_FLAGS_PIXMAP_STALE); win_clear_flags(w, WIN_FLAGS_PIXMAP_STALE);
@ -1551,16 +1543,6 @@ void win_destroy_finish(session_t *ps, struct win *w) {
free_win_res(ps, w); free_win_res(ps, w);
// Drop w from all prev_trans to avoid accessing freed memory in
// repair_win()
// TODO(yshui) there can only be one prev_trans pointing to w
wm_stack_foreach(ps->wm, cursor) {
auto w2 = wm_ref_deref(cursor);
if (w2 != NULL && w == w2->prev_trans) {
w2->prev_trans = NULL;
}
}
wm_reap_zombie(w->tree_ref); wm_reap_zombie(w->tree_ref);
free(w); free(w);
} }

4
src/wm/win.h
View file

@ -97,10 +97,6 @@ struct win {
vec2 saved_win_image_scale; vec2 saved_win_image_scale;
image_handle shadow_image; image_handle shadow_image;
image_handle mask_image; image_handle mask_image;
// TODO(yshui) only used by legacy backends, remove.
/// Pointer to the next higher window to paint.
struct win *prev_trans;
// TODO(yshui) rethink reg_ignore
// Core members // Core members
winstate_t state; winstate_t state;