PolytreeDE
/
picom
mirror of https://github.com/yshui/picom.git
1
0
Fork 0
Code Releases Activity

win: fix fading always skipped by unmap_win_start 

Fading skip needs to be based on the original value of w->ever_damaged.

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
This commit is contained in:
Yuxuan Shui 2020-12-04 04:16:50 +00:00
parent f5ee0e12e1
commit 8be379db4d
No known key found for this signature in database
GPG Key ID: D3A4405BE6CC17F4
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/win.c
View File

@ -2233,6 +2233,7 @@ void unmap_win_start(session_t *ps, struct managed_win *w) {
assert(false);
}
bool was_damaged = w->ever_damaged;
w->ever_damaged = false;
if (unlikely(w->state == WSTATE_UNMAPPING || w->state == WSTATE_UNMAPPED)) {
@ -2263,13 +2264,11 @@ void unmap_win_start(session_t *ps, struct managed_win *w) {
}
#endif
if (!ps->redirected || !w->ever_damaged) {
if (!ps->redirected || !was_damaged) {
// If we are not redirected, we skip fading because we aren't rendering
// anything anyway.
// If the window isn't ever damaged, it won't be painted either (see
// paint_preprocess), so we can skip fading. This is different from
// mapping, because a mapped window could receive damage while it's fading
// in, but an unmapped window couldn't while it's fading out.
// If the window wasn't ever damaged, it shouldn't be painted either. But
// a fading out window is always painted, so we have to skip fading here.
CHECK(!win_skip_fading(ps, w));
}
}