From ce7758a07b93a48fb272f22695fe421b07e70ace Mon Sep 17 00:00:00 2001 From: Maxim Solovyov Date: Mon, 13 Feb 2023 02:23:53 +0300 Subject: [PATCH] backend: fix leak in default_backend_render_shadow --- src/backend/backend_common.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/backend/backend_common.c b/src/backend/backend_common.c index d6fcce21..ecdefa4c 100644 --- a/src/backend/backend_common.c +++ b/src/backend/backend_common.c @@ -294,13 +294,14 @@ shadow_picture_err: void *default_backend_render_shadow(backend_t *backend_data, int width, int height, struct backend_shadow_context *sctx, struct color color) { const conv *kernel = (void *)sctx; - xcb_pixmap_t shadow_pixel = solid_picture(backend_data->c, backend_data->root, true, - 1, color.red, color.green, color.blue), - shadow = XCB_NONE; + xcb_render_picture_t shadow_pixel = solid_picture( + backend_data->c, backend_data->root, true, 1, color.red, color.green, color.blue); + xcb_pixmap_t shadow = XCB_NONE; xcb_render_picture_t pict = XCB_NONE; if (!build_shadow(backend_data->c, backend_data->root, color.alpha, width, height, kernel, shadow_pixel, &shadow, &pict)) { + xcb_render_free_picture(backend_data->c, shadow_pixel); return NULL; } @@ -308,6 +309,7 @@ void *default_backend_render_shadow(backend_t *backend_data, int width, int heig void *ret = backend_data->ops->bind_pixmap( backend_data, shadow, x_get_visual_info(backend_data->c, visual), true); xcb_render_free_picture(backend_data->c, pict); + xcb_render_free_picture(backend_data->c, shadow_pixel); return ret; }