PolytreeDE
/
polybar
mirror of https://github.com/polybar/polybar.git
1
0
Fork 0
Code Releases Activity
polybar/CHANGELOG.md

255 lines
14 KiB
Markdown
Raw Normal View History

Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
# Changelog
Release 3.5.3
2020-12-23 16:32:15 +00:00
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
All notable changes to this project will be documented in this file.
Each release should have the following subsections, if entries exist, in the
given order: `Breaking`, `Build`, `Deprecated`, `Removed`, `Added`, `Changed`,
`Fixed`, `Security`.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
## [Unreleased]
New Tag Parser (#2303) * refactor(color): Use enum class for color type * Add testcases for tag parser * Make tag parser a pull-style parser Being able to parse single elements at a time gives us more fine-grained error messages, we can also parse as much as possible and only stop after an exception. * fix(color): Parser did not check for invalid chars * tag parser: First full implementation * tag parser: Fix remaining failing tests * tag parser: Replace old parser * tag parser: Treat alignment as formatting tag Makes the structure less complex and the alignment tags really are formatting tags, they are structurally no different from the %{R} tag. * tag parser: Cleanup type definitions All type definitions for tags now live in tags/types.hpp, the parser.hpp only contains the definitions necessary for actually calling the parser, this shouldn't be included in many places (only places that actually do parsing). But many places need the definitions for the tags themselves. * Rename components/parser to tags/dispatch * tag parser: Cleanup * Add changelog
2020-12-17 19:37:28 +00:00
### Breaking
Add initial support for an escape character (#2361) Add a config parser method which, for now, deals only with escaping the literal backslash character and logs an error message to inform the user of the coming change. The error message includes a properly escaped value for the user. As a result of introducing an escape character('\'): - Warn the user of any unescaped backslashes, as they will not be treated as a literal character in the future - For now, still treat a single backslash as a literal character - Treat two consecutive backslashes as a single properly escaped literal backslash Also: - Add documentation about the escape character to polybar(5) manpage - Add info about the escape character to changelog - Add testcases for ParseLineKeyTest - Add new test ParseEscapedValueTest Resolves: First step in #2354 Improve value parsing - Take value arg in as an rvalue reference and move parsed value back - Remove unnecessary if statement - Rename function - Improve error message - Improve function description - Format Add escape character documentation to manpages Add information about the escape character to the polybar(5) manpage. Add info about the esacape character to changelog Add test cases for ParseLineKeyTest Fix ParseLineKeyTest test cases Also make config parser method parse_escaped_value private. Add tests for escaped_value_parser method Also remove unsued include statement Simplify parse_escaped_value in config_parser Remove unnecessary escaped value generation, so we do not have to keep track of index differences. Fix ParseEscapedValueTest test cases Fix parse_escaped_value Add more test cases for ParseLineKeyTest Update CHANGELOG.md Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com> Adress review - Adjust documentation - Small code changes Improve parse_escaped_value Add initial support for an escape character Add a config parser method which, for now, deals only with escaping the literal backslash character and logs an error message to inform the user of the coming change. The error message includes a properly escaped value for the user. As a result of introducing an escape character('\'): - Warn the user of any unescaped backslashes, as they will not be treated as a literal character in the future - For now, still treat a single backslash as a literal character - Treat two consecutive backslashes as a single properly escaped literal backslash Resolves: First step in #2354 Improve value parsing - Take value arg in as an rvalue reference and move parsed value back - Remove unnecessary if statement - Rename function - Improve error message - Improve function description - Format Add info about the esacape character to changelog Add test cases for ParseLineKeyTest Fix ParseLineKeyTest test cases Also make config parser method parse_escaped_value private. Add tests for escaped_value_parser method Also remove unsued include statement Simplify parse_escaped_value in config_parser Remove unnecessary escaped value generation, so we do not have to keep track of index differences. Fix ParseEscapedValueTest test cases Add more test cases for ParseLineKeyTest Adress review - Adjust documentation - Small code changes Remove duplicate testcase from ParseLineKeyTest Add initial support for an escape character Add a config parser method which, for now, deals only with escaping the literal backslash character and logs an error message to inform the user of the coming change. The error message includes a properly escaped value for the user. As a result of introducing an escape character('\'): - Warn the user of any unescaped backslashes, as they will not be treated as a literal character in the future - For now, still treat a single backslash as a literal character - Treat two consecutive backslashes as a single properly escaped literal backslash Resolves: First step in #2354 Improve value parsing - Take value arg in as an rvalue reference and move parsed value back - Remove unnecessary if statement - Rename function - Improve error message - Improve function description - Format Fix ParseLineKeyTest test cases Also make config parser method parse_escaped_value private. Remove duplicate testcase from ParseLineKeyTest
2021-01-26 18:16:29 +00:00
- We added the backslash escape character (\\) for configuration values. This
means that the literal backslash character now has special meaning in
configuration files, therefore if you want to use it in a value as a literal
backslash, you need to escape it with the backslash escape character. The
parser logs an error if any unescaped backslashes are found in a value. This
affects you only if you are using two consecutive backslashes in a value,
which will now be interpreted as a single literal backslash.
[`#2354`](https://github.com/polybar/polybar/issues/2354)
New Tag Parser (#2303) * refactor(color): Use enum class for color type * Add testcases for tag parser * Make tag parser a pull-style parser Being able to parse single elements at a time gives us more fine-grained error messages, we can also parse as much as possible and only stop after an exception. * fix(color): Parser did not check for invalid chars * tag parser: First full implementation * tag parser: Fix remaining failing tests * tag parser: Replace old parser * tag parser: Treat alignment as formatting tag Makes the structure less complex and the alignment tags really are formatting tags, they are structurally no different from the %{R} tag. * tag parser: Cleanup type definitions All type definitions for tags now live in tags/types.hpp, the parser.hpp only contains the definitions necessary for actually calling the parser, this shouldn't be included in many places (only places that actually do parsing). But many places need the definitions for the tags themselves. * Rename components/parser to tags/dispatch * tag parser: Cleanup * Add changelog
2020-12-17 19:37:28 +00:00
- We rewrote our tag parser. This shouldn't break anything, if you experience
any problems, please let us know.
The new parser now gives errors for certain invalid tags where the old parser
would just silently ignore them. Adding extra text to the end of a valid tag
now produces an error. For example, tags like `%{T-a}`, `%{T2abc}`, `%{rfoo}`,
and others will now start producing errors.
This does not affect you unless you are producing your own formatting tags
(for example in a script) and you are using one of these invalid tags.
Use sockets for IPC (#2539) Deprecates not using `polybar-msg` for IPC. Fixes #2532 Closes #2465 Fixes #2504 * Create FIFO specific NamedPipeHandle subclass to PipeHandle * Prototype SocketHandle * Move mainloop up to main.cpp * Pass eventloop to ipc class * Deprecate sending ipc over the named pipe Unfortunately, we can only show the warning in the polybar log and not give the user any feedback because the pipe is one-way * Move eventloop into its own namespace * Prototype ipc socket handling * Remove handles from ipc_client Should be independent from eventloop logic * Remove ipc clients when finished * Add tests for ipc_client decoding * Add callback for complete ipc messages * Remove template param from mixins * Move signal handler to new callback system * Move poll handle to new callback system * Move FSEventHandle to new callback system * Move TimerHandle and AsyncHandle to new callback system * Move PipeHandle to new callback system * Implement socket functionality in new callback system * Correctly reset ipc named pipe handle * Let client close handles in error callback * Wrap client pipe and ipc::client in connection class * Better decoder log messages * Socket path logic * Fix CI warnings * Remove UVHandleGeneric * Fix error when socket folder already exists * Proof of concept message writeback * Restructure ipc files * polybar-msg: Use sockets * polybar-msg: Better syntax for actions * Fix memory leak with fifo After EOF, the pipe wasn't closed and EOF was called all the time, each time allocating a new pipe. * Make polybar-msg compile on its own * Rudimentary writeback for polybar-msg * Fix payload reference going out of scope. * Add IPC documentation * Cleanup polybar-msg code * Specify the v0 ipc message format * Close ipc connection after message * Fix ipc tests * Properly close ipc connections * Fix polybar-msg not working with action string * Write polybar-msg manpage * polybar-msg: Stop using exit() * ipc: Print log message with PID * Add tests for ipc util * polybar-msg: Print PID with success message * ipc: Propagate message errors * Rename ipc::client to ipc::decoder * Rename ipc.cpp to polybar-msg.cpp * ipc: Write encoder function and fix decoder bugs * ipc: Use message format for responses * ipc: Handle wrong message types * ipc: Write back error message if ipc message cannot be processed This only happens for commands and empty actions. Non-empty actions are not immediately executed, but deferred until the next loop iteration. * Remove TODO about deleting runtime directory The socket file is not deleted after socket.close() is called, only after libuv executes the close callback. So we can't just call rmdir because it will probably always fail. * CLeanup WriteRequest * Update manpage authors * Cleanup
2022-01-22 19:35:37 +00:00
- For security reasons, the named pipe at `/tmp/polybar_mqueue.<PID>` had its
permission bits changed from `666` to `600` to prevent sending ipc messages
to polybar processes running under a different user.
New Tag Parser (#2303) * refactor(color): Use enum class for color type * Add testcases for tag parser * Make tag parser a pull-style parser Being able to parse single elements at a time gives us more fine-grained error messages, we can also parse as much as possible and only stop after an exception. * fix(color): Parser did not check for invalid chars * tag parser: First full implementation * tag parser: Fix remaining failing tests * tag parser: Replace old parser * tag parser: Treat alignment as formatting tag Makes the structure less complex and the alignment tags really are formatting tags, they are structurally no different from the %{R} tag. * tag parser: Cleanup type definitions All type definitions for tags now live in tags/types.hpp, the parser.hpp only contains the definitions necessary for actually calling the parser, this shouldn't be included in many places (only places that actually do parsing). But many places need the definitions for the tags themselves. * Rename components/parser to tags/dispatch * tag parser: Cleanup * Add changelog
2020-12-17 19:37:28 +00:00
build: Bump cmake version to 3.5.0 This includes the changes from polybar/xpp#30 which also updates the minimum cmake version in the xpp submodule
2020-12-22 00:58:21 +00:00
### Build
Update CHANGELOG.md
2021-09-13 18:30:15 +00:00
- New dependency: [libuv](https://github.com/libuv/libuv). At least version 1.3
is required.
build: Bump cmake version to 3.5.0 This includes the changes from polybar/xpp#30 which also updates the minimum cmake version in the xpp submodule
2020-12-22 00:58:21 +00:00
- Bump the minimum cmake version to 3.5
refactor(cmake): Allow targets to be enabled individually Each major target of polybar can now be enabled/disabled while configuring (even polybar itself). The cmake code specific to each target will only run if the target is enabled. This allows us to for example just build the documentation without having to run all the cmake code related to compilation or having the polybar dependencies installed (other than sphinx).
2020-12-22 02:43:06 +00:00
- The `BUILD_IPC_MSG` option has been renamed to `BUILD_POLYBAR_MSG`
- Building the documentation is now enabled by default and not just when
`sphinx-build` is found.
- Users can control exactly which targets should be available with the following
cmake options (together with their default value):
- `BUILD_POLYBAR=ON` - Builds the `polybar` executable
- `BUILD_POLYBAR_MSG=ON` - Builds the `polybar-msg` executable
- `BUILD_TESTS=OFF` - Builds the test suite
- `BUILD_DOC=ON` - Builds the documentation
build: Add option to enable/disable html/manpages
2020-12-22 11:29:26 +00:00
- `BUILD_DOC_HTML=BUILD_DOC` - Builds the html documentation (depends on `BUILD_DOC`)
- `BUILD_DOC_MAN=BUILD_DOC` - Builds the manpages (depends on `BUILD_DOC`)
Create default config (#2511) * Create default config and install to /etc/polybar Closes #2405 * Search for config in /etc We search in XDG_CONFIG_DIRS, /etc/xdg, and /etc but only for config.ini Closes #2016 * Remove config installation from build.sh * Remove userconfig cmake file * Cleanup * Cleanup default config * Update CHANGELOG.md Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Update src/main.cpp Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Add tests for string functions * Support loading bars from fallbacks in /etc * Combine duplicate string_util::contains test Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com>
2021-10-05 11:07:19 +00:00
- `BUILD_CONFIG=ON` - Generates the default config
Cleanup
2020-12-24 01:02:53 +00:00
- `BUILD_SHELL=ON` - Generates shell completion files
refactor(cmake): Allow targets to be enabled individually Each major target of polybar can now be enabled/disabled while configuring (even polybar itself). The cmake code specific to each target will only run if the target is enabled. This allows us to for example just build the documentation without having to run all the cmake code related to compilation or having the polybar dependencies installed (other than sphinx).
2020-12-22 02:43:06 +00:00
- `DISABLE_ALL=OFF` - Disables all above targets by default. Individual
targets can still be enabled explicitly.
- The documentation can no longer be built by directly configuring the `doc`
directory.
Cleanup
2020-12-24 01:02:53 +00:00
- The sample config file is now placed in the `generated-sources` folder inside
whatever folder you invoked `cmake` from instead of in the root folder of the
repository.
cmake: Stop using CMAKE_* variables for flags It is not recommended anyway and the -Werror flag set in CI was getting set when compiling gtest, breaking our build.
2021-07-11 12:11:58 +00:00
- The `POLYBAR_FLAGS` cmake variable can be used to pass extra C++ compiler flags.
Create default config (#2511) * Create default config and install to /etc/polybar Closes #2405 * Search for config in /etc We search in XDG_CONFIG_DIRS, /etc/xdg, and /etc but only for config.ini Closes #2016 * Remove config installation from build.sh * Remove userconfig cmake file * Cleanup * Cleanup default config * Update CHANGELOG.md Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Update src/main.cpp Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Add tests for string functions * Support loading bars from fallbacks in /etc * Combine duplicate string_util::contains test Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com>
2021-10-05 11:07:19 +00:00
- The sample config file has been removed.
- Polybar now ships a default config that is installed to
`/etc/polybar/config.ini`, it lives in `doc/config.ini`.
It will also be placed in the `examples` directory in the documentation folder.
[`#2405`](https://github.com/polybar/polybar/issues/2405)
- The `userconfig` target has been removed, you can no longer use `make
userconfig`. As an alternative, you can copy the default config from
`/etc/polybar/config.ini`.
build: Bump cmake version to 3.5.0 This includes the changes from polybar/xpp#30 which also updates the minimum cmake version in the xpp submodule
2020-12-22 00:58:21 +00:00
Deprecate throttle-output and throttle-output-for The eventloop no longer uses them. libuv will coalesces multiple uv_async_send if they happen one after another and this also leads to coalescing of updates.
2021-09-12 20:48:27 +00:00
### Deprecated
- `[settings]`: `throttle-output` and `throttle-output-for` have been removed.
The new event loop already does a similar thing where it coalesces update
triggers if they happen directly after one another, leading to only a single
bar update.
Create default config (#2511) * Create default config and install to /etc/polybar Closes #2405 * Search for config in /etc We search in XDG_CONFIG_DIRS, /etc/xdg, and /etc but only for config.ini Closes #2016 * Remove config installation from build.sh * Remove userconfig cmake file * Cleanup * Cleanup default config * Update CHANGELOG.md Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Update src/main.cpp Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Add tests for string functions * Support loading bars from fallbacks in /etc * Combine duplicate string_util::contains test Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com>
2021-10-05 11:07:19 +00:00
- When not specifying the config file with `--config`, naming your config file
`config` is deprecated. Rename your config file to `config.ini`.
Use sockets for IPC (#2539) Deprecates not using `polybar-msg` for IPC. Fixes #2532 Closes #2465 Fixes #2504 * Create FIFO specific NamedPipeHandle subclass to PipeHandle * Prototype SocketHandle * Move mainloop up to main.cpp * Pass eventloop to ipc class * Deprecate sending ipc over the named pipe Unfortunately, we can only show the warning in the polybar log and not give the user any feedback because the pipe is one-way * Move eventloop into its own namespace * Prototype ipc socket handling * Remove handles from ipc_client Should be independent from eventloop logic * Remove ipc clients when finished * Add tests for ipc_client decoding * Add callback for complete ipc messages * Remove template param from mixins * Move signal handler to new callback system * Move poll handle to new callback system * Move FSEventHandle to new callback system * Move TimerHandle and AsyncHandle to new callback system * Move PipeHandle to new callback system * Implement socket functionality in new callback system * Correctly reset ipc named pipe handle * Let client close handles in error callback * Wrap client pipe and ipc::client in connection class * Better decoder log messages * Socket path logic * Fix CI warnings * Remove UVHandleGeneric * Fix error when socket folder already exists * Proof of concept message writeback * Restructure ipc files * polybar-msg: Use sockets * polybar-msg: Better syntax for actions * Fix memory leak with fifo After EOF, the pipe wasn't closed and EOF was called all the time, each time allocating a new pipe. * Make polybar-msg compile on its own * Rudimentary writeback for polybar-msg * Fix payload reference going out of scope. * Add IPC documentation * Cleanup polybar-msg code * Specify the v0 ipc message format * Close ipc connection after message * Fix ipc tests * Properly close ipc connections * Fix polybar-msg not working with action string * Write polybar-msg manpage * polybar-msg: Stop using exit() * ipc: Print log message with PID * Add tests for ipc util * polybar-msg: Print PID with success message * ipc: Propagate message errors * Rename ipc::client to ipc::decoder * Rename ipc.cpp to polybar-msg.cpp * ipc: Write encoder function and fix decoder bugs * ipc: Use message format for responses * ipc: Handle wrong message types * ipc: Write back error message if ipc message cannot be processed This only happens for commands and empty actions. Non-empty actions are not immediately executed, but deferred until the next loop iteration. * Remove TODO about deleting runtime directory The socket file is not deleted after socket.close() is called, only after libuv executes the close callback. So we can't just call rmdir because it will probably always fail. * CLeanup WriteRequest * Update manpage authors * Cleanup
2022-01-22 19:35:37 +00:00
- Directly writing ipc messages to `/tmp/polybar_mqueue.<PID>` is deprecated,
users should always use `polybar-msg`. As a consequence the message format
used for IPC is deprecated as well.
Eventloop cleanup (#2577) * eventloop: Use eventloop namespace in cpp files * changelog: Add missing deprecated hook message * Make eventloop and ipc classes non-copyable and non-movable * Remove functional.hpp * eventloop: Don't close handles in error cases Client should be responsible for closing handles. * eventloop: Address invalidation of handle references
2022-01-22 21:00:26 +00:00
- `polybar-msg hook` is deprecated in favor of using the hook action.
`polybar-msg` will tell you the correct command to use.
Deprecate throttle-output and throttle-output-for The eventloop no longer uses them. libuv will coalesces multiple uv_async_send if they happen one after another and this also leads to coalescing of updates.
2021-09-12 20:48:27 +00:00
Integrate bar taskqueue into eventloop (#2510) * Remove DEBUG_SHADED Was disabled by default AND behind an #if 0 * Make TimerHandle expose more libuv functions * Prepare for moving double clicks into eventloop * Make eventloop available to bar * Remove bar mutex Everything in the bar is now in the same thread * Move double-click handling to eventloop * Extract double click deferred function into method * Stop throttling clicks * Increase double click interval to 400 and add option double-click-interval in the bar section Closes #1441 * Implement dimming using timer handles * Remove taskqueue * Remove unused dependencies * Cleanup & Comments
2021-09-27 15:35:45 +00:00
### Removed
- `DEBUG_SHADED` cmake variable and its associated functionality.
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
### Added
feat(alsa): add middle and right mouse button events (#2573) * Add events to alsa module * Update CHANGELOG * Update CHANGELOG.md Closes #2566 Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2022-01-18 18:51:49 +00:00
- Right and middle click events for alsa module.
([`#2566`](https://github.com/polybar/polybar/issues/2566))
Clean up changelog (#2571)
2022-01-16 04:12:45 +00:00
- `internal/network`: New token `%mac%` shows MAC address of selected interface
([`#2568`](https://github.com/polybar/polybar/issues/2568))
feat: Support reading config from non-regular files (#2545) We had a check that restricted config files to "regular files". This check was to restrictive as it didn't allow for things like: ``` polybar -c <(gen_config) gen_config | polybar -c /dev/stdin ``` Now, polybar can easily read config data from stdin.
2021-10-24 09:25:05 +00:00
- Polybar can now read config files from stdin: `polybar -c /dev/stdin`.
Update CHANGLELOG.md
2021-09-28 19:26:08 +00:00
- `custom/script`: Implement `env-*` config option.
Clean up changelog (#2571)
2022-01-16 04:12:45 +00:00
([`#2090`](https://github.com/polybar/polybar/issues/2090))
feat(ramp): Allow specifying ramp weights (#2505) * feat(ramp) Implement ramp weights *Add test for ramp weights *[drawtypes/ramp] Implement ramp weights Simply clone `label_t` weight no. of times in the icon list This helps us not to change any of the calculations. *Fix silly bug Forgot to add a hyphen for the `weight` parameter. Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com> *doc: add #1750 to CHANGELOG * Fix compile error in ramp test Use std::make_shared.
2021-09-22 19:46:20 +00:00
- `drawtypes/ramp`: Add support for ramp weights.
Clean up changelog (#2571)
2022-01-16 04:12:45 +00:00
([`#1750`](https://github.com/polybar/polybar/issues/1750))
Integrate bar taskqueue into eventloop (#2510) * Remove DEBUG_SHADED Was disabled by default AND behind an #if 0 * Make TimerHandle expose more libuv functions * Prepare for moving double clicks into eventloop * Make eventloop available to bar * Remove bar mutex Everything in the bar is now in the same thread * Move double-click handling to eventloop * Extract double click deferred function into method * Stop throttling clicks * Increase double click interval to 400 and add option double-click-interval in the bar section Closes #1441 * Implement dimming using timer handles * Remove taskqueue * Remove unused dependencies * Cleanup & Comments
2021-09-27 15:35:45 +00:00
- `internal/memory`: New tokens `%used%`, `%free%`, `%total%`, `%swap_total%`,
feat(memory): Tokens that switch between MiB and GiB (#2488) * feat:add tokens to display memory in MiB when GiB val <= 1.0 (#2472) * fix: correct swap_used calculation * fix: pass variable by reference rather than by value * fix: add precision arguments to filesize_gib_mib(); better condition * doc: add #2472 to CHANGELOG * fix: missing default argument values * Apply suggestions from code review Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2021-09-04 11:14:13 +00:00
`%swap_free%`, and `%swap_used%` that automatically switch between MiB and GiB
when below or above 1GiB.
Clean up changelog (#2571)
2022-01-16 04:12:45 +00:00
([`#2472`](https://github.com/polybar/polybar/issues/2472))
feat(conf): Option to always show urgent workspaces in i3 (#2378) When `pin-workspaces` is set to true using `show-urgent` will show urgent workspaces on the bar even when the workspace is not associated with the current monitor.
2021-02-15 20:31:34 +00:00
- Option to always show urgent windows in i3 module when `pin-workspace` is active
Clean up changelog (#2571)
2022-01-16 04:12:45 +00:00
([`#2374`](https://github.com/polybar/polybar/issues/2374))
add reverse-scroll option for xworkspaces module (#2365) * add reverse-scroll option for xworkspaces module * move use of reverse-scroll option to when producing scroll action * documented xworkspaces reverse-scroll option in changelog
2021-01-28 09:11:33 +00:00
- `internal/xworkspaces`: `reverse-scroll` can be used to reverse the scroll
direction when cycling through desktops.
Add initial support for an escape character (#2361) Add a config parser method which, for now, deals only with escaping the literal backslash character and logs an error message to inform the user of the coming change. The error message includes a properly escaped value for the user. As a result of introducing an escape character('\'): - Warn the user of any unescaped backslashes, as they will not be treated as a literal character in the future - For now, still treat a single backslash as a literal character - Treat two consecutive backslashes as a single properly escaped literal backslash Also: - Add documentation about the escape character to polybar(5) manpage - Add info about the escape character to changelog - Add testcases for ParseLineKeyTest - Add new test ParseEscapedValueTest Resolves: First step in #2354 Improve value parsing - Take value arg in as an rvalue reference and move parsed value back - Remove unnecessary if statement - Rename function - Improve error message - Improve function description - Format Add escape character documentation to manpages Add information about the escape character to the polybar(5) manpage. Add info about the esacape character to changelog Add test cases for ParseLineKeyTest Fix ParseLineKeyTest test cases Also make config parser method parse_escaped_value private. Add tests for escaped_value_parser method Also remove unsued include statement Simplify parse_escaped_value in config_parser Remove unnecessary escaped value generation, so we do not have to keep track of index differences. Fix ParseEscapedValueTest test cases Fix parse_escaped_value Add more test cases for ParseLineKeyTest Update CHANGELOG.md Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com> Adress review - Adjust documentation - Small code changes Improve parse_escaped_value Add initial support for an escape character Add a config parser method which, for now, deals only with escaping the literal backslash character and logs an error message to inform the user of the coming change. The error message includes a properly escaped value for the user. As a result of introducing an escape character('\'): - Warn the user of any unescaped backslashes, as they will not be treated as a literal character in the future - For now, still treat a single backslash as a literal character - Treat two consecutive backslashes as a single properly escaped literal backslash Resolves: First step in #2354 Improve value parsing - Take value arg in as an rvalue reference and move parsed value back - Remove unnecessary if statement - Rename function - Improve error message - Improve function description - Format Add info about the esacape character to changelog Add test cases for ParseLineKeyTest Fix ParseLineKeyTest test cases Also make config parser method parse_escaped_value private. Add tests for escaped_value_parser method Also remove unsued include statement Simplify parse_escaped_value in config_parser Remove unnecessary escaped value generation, so we do not have to keep track of index differences. Fix ParseEscapedValueTest test cases Add more test cases for ParseLineKeyTest Adress review - Adjust documentation - Small code changes Remove duplicate testcase from ParseLineKeyTest Add initial support for an escape character Add a config parser method which, for now, deals only with escaping the literal backslash character and logs an error message to inform the user of the coming change. The error message includes a properly escaped value for the user. As a result of introducing an escape character('\'): - Warn the user of any unescaped backslashes, as they will not be treated as a literal character in the future - For now, still treat a single backslash as a literal character - Treat two consecutive backslashes as a single properly escaped literal backslash Resolves: First step in #2354 Improve value parsing - Take value arg in as an rvalue reference and move parsed value back - Remove unnecessary if statement - Rename function - Improve error message - Improve function description - Format Fix ParseLineKeyTest test cases Also make config parser method parse_escaped_value private. Remove duplicate testcase from ParseLineKeyTest
2021-01-26 18:16:29 +00:00
- The backslash escape character (\\).
[`#2354`](https://github.com/polybar/polybar/issues/2354)
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
- Warn states for the cpu, memory, fs, and battery modules.
([`#570`](https://github.com/polybar/polybar/issues/570),
[`#956`](https://github.com/polybar/polybar/issues/956),
[`#1871`](https://github.com/polybar/polybar/issues/1871),
[`#2141`](https://github.com/polybar/polybar/issues/2141))
feat(config): Try to load config.ini (#2324) * Added .ini extension check to default config * Added change to changelog and man page * Added change to changelog and man page * removed .vscode folder * removed new lines in changelog
2020-12-23 16:52:30 +00:00
- `internal/battery`: `format-low`, `label-low`, `animation-low`, `low-at = 10`.
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
- `internal/cpu`: `format-warn`, `label-warn`, `warn-percentage = 80`
- `internal/fs`: `format-warn`, `label-warn`, `warn-percentage = 90`
- `internal/memory`: `format-warn`, `label-warn`, `warn-percentage = 90`
feat: Rounded bar border (#2359) * Added rounded border * Added feature to the changelog * Changed implementation for better customisation * Bugfixes * Removed commented code * Removed unused method * Removed duplicate lines * Moved degree to be a private constant Co-authored-by: Simon <simondergruber@gmail.com>
2021-02-16 22:17:16 +00:00
- `radius` now affects the bar border as well
fix: unbounded_percentage always rounded down For example if lower / upper = 0.019 (1.9%), it would return 1% instead of 2% Fixes #2399
2021-03-03 21:38:05 +00:00
([`#1566`](https://github.com/polybar/polybar/issues/1566))
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
- Per-corner corner radius with `radius-{bottom,top}-{left,right}`
([`#2294`](https://github.com/polybar/polybar/issues/2294))
- `internal/network`: `speed-unit = B/s` can be used to customize how network
speeds are displayed.
feat(xkeyboard): Add variant support to layout label (#2163) * Add variant support to xkeyboard layout label Solves #316 * Run style checks, I guess? * Add comment * Return nothing if there is no variant * Update CHANGELOG
2020-12-19 17:22:27 +00:00
- `internal/xkeyboard`: `%variant%` can be used to parse the layout variant
([`#316`](https://github.com/polybar/polybar/issues/316))
Add config option for visiblity (#2320 cont'd) (#2342) * Add option * Undo my havoc on the example config * Update CHANGELOG
2021-01-03 01:43:50 +00:00
- Config option to hide a certain module
(`hidden = false`)
([`#2108`](https://github.com/polybar/polybar/issues/2108))
Universal Visibility Action (#2320 cont'd) (#2426) * Add toggle_visible action * Add set_visible and set_invisible actions * Rename toggle_visible method to match `action_toggle_visible` -> `action_toggle_visibility` Matches with `EVENT_TOGGLE_VISIBILITY` * Update CHANGELOG * Revert #2320 IPC commands IPC commands are no longer necessary now that the actions are implemented. Changed some method permissions as well to reflect this. * Add logging and change action names - `module_toggle` - `module_show` - `module_hide` Delineate common actions to all modules with a `module_` prefix (for future actions too) * Update documentation
2021-07-07 19:43:49 +00:00
- Actions to control visibility of modules
(`module_toggle`, `module_show`, and `module_hide`)
([`#2108`](https://github.com/polybar/polybar/issues/2108))
feat(xworkspaces): Persistent urgent hint (#2340) * add urgent hint * feat(xworkspaces): Fully implement urgency hint Co-authored-by: Jérôme BOULMIER <jerome.boulmier@outlook.fr>
2020-12-31 14:49:39 +00:00
- `internal/xworkspaces`: Make the urgent hint persistent
([`#1081`](https://github.com/polybar/polybar/issues/1081))
feat(net): interface discovery (#2025)
2021-01-03 10:48:15 +00:00
- `internal/network`: `interface-type` may be used in place of `interface` to
automatically select a network interface
([`#2025`](https://github.com/polybar/polybar/pull/2025))
Add support for %nwin% in xworkspaces label (#2329) %nwin% tells the number of windows in a workspace
2021-01-04 09:17:27 +00:00
- `internal/xworkspaces`: `%nwin%` can be used to display the number of open
windows per workspace
([`#604`](https://github.com/polybar/polybar/issues/604))
feat(backlight): add use-actual-brightness option (#2380) * add use-actual-brightness option * added to changelog * added to changelog 2 * added to changelog 3
2021-02-16 09:02:33 +00:00
- `internal/backlight`: added `use-actual-brightness` option
Add wm-restack=generic option that lowers polybar to the bottom of the stack (#2404) * Add wm-restack=generic to lower polybar to the bottom of the stack Previously wm-restack only supported bspwm and i3. Both have a special top-level window that polybar detects and places itself directly above. This patch adds wm-restack=generic which simply lowers polybar to the very bottom of the stack. This option was tested and confirmed to work with xmonad which doesn't have a special top-level window and therefore doesn't require special handling like bspwm and i3. Fixes #2205 * Update src/components/bar.cpp Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2021-04-01 22:48:48 +00:00
- Added `wm-restack = generic` option that lowers polybar to the bottom of the stack.
Fixes the issue where the bar is being drawn on top of fullscreen windows in xmonad.
([`#2205`](https://github.com/polybar/polybar/issues/2205))
feat(bspwm): Option to scroll through occupied desktops only (#2428) * Implement option occupied-scroll to bspwm module * update changelog * change default value of the setting
2021-05-13 10:59:13 +00:00
- Added `occupied-scroll = true` option to bspwm module.
Allows scrolling only through occupied desktops only.
([`#2427`](https://github.com/polybar/polybar/issues/2427))
feat(ipc): allow receiving arbitrary text on IPC socket (#2463) This adds the 'send' action to the ipc module that can be used to send arbitrary text to the module: polybar-msg action "#ipc.send.%{F#4444ff}hello%{F-}" * feat(ipc): allow receiving arbitrary text on IPC socket Instead of just allowing hook numbers to be executed, the user can send arbitrary text and the IPC module will put it in the bar. The IPC payload format is extended to accept an arbitrary string if the first character after the module name is ':'. polybar-msg hook test :'%{F#4444ff}hello%{F-}' Fix #2455 * Use actions for sending data to ipc module * ipc: Don't use exceptions when no hooks are defined * Update src/modules/ipc.cpp Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-07-11 18:42:28 +00:00
- `custom/ipc`: `send` action to send arbitrary strings to be displayed in the module.
([`#2455`](https://github.com/polybar/polybar/issues/2455))
Integrate bar taskqueue into eventloop (#2510) * Remove DEBUG_SHADED Was disabled by default AND behind an #if 0 * Make TimerHandle expose more libuv functions * Prepare for moving double clicks into eventloop * Make eventloop available to bar * Remove bar mutex Everything in the bar is now in the same thread * Move double-click handling to eventloop * Extract double click deferred function into method * Stop throttling clicks * Increase double click interval to 400 and add option double-click-interval in the bar section Closes #1441 * Implement dimming using timer handles * Remove taskqueue * Remove unused dependencies * Cleanup & Comments
2021-09-27 15:35:45 +00:00
- Added `double-click-interval` setting to the bar section to control the time
interval in which a double-click is recognized. Defaults to 400 (ms)
([`#1441`](https://github.com/polybar/polybar/issues/1441))
feat(xkeyboard): Icon matching using variant (#2521) * feat(string_util): add contains_nocase * feat(xkeyboard): Enable icon by variant * Cleanup * string_util: add some cases to string test * string_util: rename contains_nocase -> contains_ignore_case * layouticonset: use contains_ignore_case * layouticonset: apply renamings and remove dead code * remove VARIANT_NONE and use empty string instead * use emplace_back and add assert * layouticonset: precompute condition * xkeyboard: restore missing continue * Cleanup parse_icons * Always choose the first case-insensitive match * Cleanup layouticonset.get * update the changelog Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-10-05 10:12:47 +00:00
- `internal/xkeyboard`: Allow configuring icons using variant
([`#2414`](https://github.com/polybar/polybar/issues/2414))
feat(ipc): hook, prev, next, reset module actions (#2528) * WIP ipc actions * feat(ipc): Add hook, prev, next and reset actions Closes: #2464 * ipc: format code * ipc: fix comparison * Apply suggestions from code review Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com> * ipc: make index 0-based * ipc: add 0-based indexing breaking change to Changelog * ipc: restore 1-based index for and message * ipc: fix initial=0 throwing an error Co-authored-by: Martin Terneborg <martinterneborg@protonmail.com> Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2021-10-10 18:22:24 +00:00
- `custom/ipc`: Add `hook`, `next`, `prev`, `reset` actions to the ipc module
([`#2464`](https://github.com/polybar/polybar/issues/2464))
Add support for a `tray-foreground` setting. (#2552) This adds a new `tray-foreground` config option, and uses it instead of the `tray-background` setting to build up the `_NET_SYSTEM_TRAY_COLORS` property. I'm pretty sure that the previous behavior was a mistake (this was introduced in 94298741b6de08e79131006504850820bdff9024 which is a pretty large diff). For me and some other people, this results in a black icon being drawn on top of a black background, which is pretty useless! I would say that this diff fixes https://github.com/polybar/polybar/issues/2235. Note: the old code dealt with `unsigned int` and maxed values out at 0xff. The new code deals with `uint16_t` and maxes values out at 0xffff. I haven't found the relevant documentation to justify this change, but from manually testing, I'm pretty confident this is the right change. This all matches pretty closely with this code from i3: [`i3bar/src/xcb.c::init_tray_colors` code](https://github.com/i3/i3/blob/43e805a00d1835db4fc0730ce5003956824b350d/i3bar/src/xcb.c#L1490-L1522), which you can see also uses the bar's foreground color and maxes values out at 0xffff, not 0xff. If you merge this up, I think we should also update https://github.com/polybar/polybar/wiki/Configuration#bar-settings to mention the new settings. Fixes #2235
2021-11-17 10:41:40 +00:00
- Added a new `tray-foreground` setting to give hints to tray icons about what
color they should be.
([#2235](https://github.com/polybar/polybar/issues/2235))
Use sockets for IPC (#2539) Deprecates not using `polybar-msg` for IPC. Fixes #2532 Closes #2465 Fixes #2504 * Create FIFO specific NamedPipeHandle subclass to PipeHandle * Prototype SocketHandle * Move mainloop up to main.cpp * Pass eventloop to ipc class * Deprecate sending ipc over the named pipe Unfortunately, we can only show the warning in the polybar log and not give the user any feedback because the pipe is one-way * Move eventloop into its own namespace * Prototype ipc socket handling * Remove handles from ipc_client Should be independent from eventloop logic * Remove ipc clients when finished * Add tests for ipc_client decoding * Add callback for complete ipc messages * Remove template param from mixins * Move signal handler to new callback system * Move poll handle to new callback system * Move FSEventHandle to new callback system * Move TimerHandle and AsyncHandle to new callback system * Move PipeHandle to new callback system * Implement socket functionality in new callback system * Correctly reset ipc named pipe handle * Let client close handles in error callback * Wrap client pipe and ipc::client in connection class * Better decoder log messages * Socket path logic * Fix CI warnings * Remove UVHandleGeneric * Fix error when socket folder already exists * Proof of concept message writeback * Restructure ipc files * polybar-msg: Use sockets * polybar-msg: Better syntax for actions * Fix memory leak with fifo After EOF, the pipe wasn't closed and EOF was called all the time, each time allocating a new pipe. * Make polybar-msg compile on its own * Rudimentary writeback for polybar-msg * Fix payload reference going out of scope. * Add IPC documentation * Cleanup polybar-msg code * Specify the v0 ipc message format * Close ipc connection after message * Fix ipc tests * Properly close ipc connections * Fix polybar-msg not working with action string * Write polybar-msg manpage * polybar-msg: Stop using exit() * ipc: Print log message with PID * Add tests for ipc util * polybar-msg: Print PID with success message * ipc: Propagate message errors * Rename ipc::client to ipc::decoder * Rename ipc.cpp to polybar-msg.cpp * ipc: Write encoder function and fix decoder bugs * ipc: Use message format for responses * ipc: Handle wrong message types * ipc: Write back error message if ipc message cannot be processed This only happens for commands and empty actions. Non-empty actions are not immediately executed, but deferred until the next loop iteration. * Remove TODO about deleting runtime directory The socket file is not deleted after socket.close() is called, only after libuv executes the close callback. So we can't just call rmdir because it will probably always fail. * CLeanup WriteRequest * Update manpage authors * Cleanup
2022-01-22 19:35:37 +00:00
- `polybar-msg`: For module actions, you can now also specify the module name,
action name, and optional data as separate arguments.
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
### Changed
Create default config (#2511) * Create default config and install to /etc/polybar Closes #2405 * Search for config in /etc We search in XDG_CONFIG_DIRS, /etc/xdg, and /etc but only for config.ini Closes #2016 * Remove config installation from build.sh * Remove userconfig cmake file * Cleanup * Cleanup default config * Update CHANGELOG.md Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Update src/main.cpp Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com> * Add tests for string functions * Support loading bars from fallbacks in /etc * Combine duplicate string_util::contains test Co-authored-by: dvermd <315743+dvermd@users.noreply.github.com>
2021-10-05 11:07:19 +00:00
- Polybar now also reads `config.ini` when searching for config files.
([`#2323`](https://github.com/polybar/polybar/issues/2323))
- Polybar additionally searches in `XDG_CONFIG_DIRS/polybar` (or
`/etc/xdg/polybar` if it is not set) and `/etc/polybar` for config files
(only `config.ini`).
([`#2016`](https://github.com/polybar/polybar/issues/2016))
Update CHANGELOG.md
2021-09-13 18:30:15 +00:00
- We rewrote polybar's main event loop. This shouldn't change any behavior for
the user, but be on the lookout for X events, click events, or ipc messages
not arriving and the bar not shutting down/restarting properly and let us
know if you find any issues.
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
- Slight changes to the value ranges the different ramp levels are responsible
for in the cpu, memory, fs, and battery modules. The first and last level are
only used for everything at or below and at and above the edges of the value
range, respectively. The other levels are evenly distributed over the value
range as before.
- `custom/script`: `interval` now defaults to 0 if `tail = true` as per the
documentation.
- `internal/network`:
- Increased precision for upload and download speeds: 0 decimal places for
KB/s (as before), 1 for MB/s and 2 for GB/s.
Integrate bar taskqueue into eventloop (#2510) * Remove DEBUG_SHADED Was disabled by default AND behind an #if 0 * Make TimerHandle expose more libuv functions * Prepare for moving double clicks into eventloop * Make eventloop available to bar * Remove bar mutex Everything in the bar is now in the same thread * Move double-click handling to eventloop * Extract double click deferred function into method * Stop throttling clicks * Increase double click interval to 400 and add option double-click-interval in the bar section Closes #1441 * Implement dimming using timer handles * Remove taskqueue * Remove unused dependencies * Cleanup & Comments
2021-09-27 15:35:45 +00:00
- Clicks arriving in close succession, no longer get dropped. Before polybar
would drop any click that arrived within 5ms of the previous one.
- Increased the double click interval from 150ms to 400ms.
Notification string to a queue of strings (#2517) Fixes #2469 * made inputdata to queue<string> * changed back to front * fixed move semantics issue while popping queue * Removed ide file * commented test lines * review changes * review changes * Update CHANGELOG.md * Cleanup Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-10-03 09:24:24 +00:00
- Stop ignoring actions if they arrive while the previous one hasn't been processed yet.
([`#2469`](https://github.com/polybar/polybar/issues/2469))
The xworkspaces module should wait for EWMH to become available (#2429) * The xworkspaces module should wait for EWMH to become available Before this change if EWMH wasn't available the xworkspaces module was permanently disabled. When polybar was started alongside the window manager e.g. from .xinitrc this caused a race condition between polybar and the window manager and the xworkspaces module may or may not be displayed. After this change polybar will wait for EWMH to become available. This change closes #1915, see that issue for more details. Curiously this only required the removal of the error condition which used the be raised when EWMH wasn't available. The xworkspaces module will show up on the bar as soon as the first EWMH event is processed by the existing event handling code. I can't argue much about the correctness of this patch but it seems to work flawlessly in my testing with xmonad. I didn't test any other window managers. Note that removing the error condition below which checks that _NET_DESKTOP_VIEWPORT is available might make this work with pin-workspaces=true. I couldn't test the effects of that change because I only tested with xmonad and xmonad doesn't support _NET_DESKTOP_VIEWPORT, so I didn't make that change. * xworkspaces: Remove check fo _NET_DESKTOP_VIEWPORT Implementations that don't support it will just return an empty list for get_desktop_viewports and pin-workspaces won't do anything. * Update changelog Fixes #1915 Co-authored-by: Tim Schumacher <tim@timakro.de> Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-10-11 12:40:14 +00:00
- Polybar can now be run without passing the bar name as argument given that
Allow running polybar without BAR argument (#2526) * Allow running polybar without BAR argument The configuration file must declare a single bar to be able to not name it. * Check barname not in config and improve error message * Revert README changes * Add no bar in config file error detection
2021-10-07 12:48:47 +00:00
the configuration file only defines one bar
([`#2525`](https://github.com/polybar/polybar/issues/2525))
Handle relative includes (#2535) * Handle relative includes We change to the directory of the given config file before parsing. This allows us to handle relative includes. TODO: Maybe improve the name of the change_dir() function. * Fix unused result warning * Add `relative_to` parameter to expand() If the path is relative, we resolve it by prepending dirname(config) to the path. Add dirname() - Returns the parent directory of the file or an empty string. * Resolve relative paths Handle paths relative to the current file being parsed. * Remove unneeded change_dir() * Fix expand() `is_absolute` is calculated after we expand the path. `relative_to` must be a directory. Add test for expand() with relative paths * Recalculate `is_absolute` after expanding `path` * Add more file_util::expand tests * Add changelog Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-10-20 10:31:15 +00:00
- `include-directory` and `include-file` now support relative paths. The paths
are relative to the folder of the file where those directives appear.
([`#2523`](https://github.com/polybar/polybar/issues/2523))
fix(ipc): don't format empty strings (#2549) * fix(ipc): don't format empty strings * Add a description of the change to `CHANGELOG.md` * Rephrasing
2021-11-04 15:55:16 +00:00
- `custom/ipc`: Empty output strings are no longer formatted. This prevents
extraneous spaces and separators from appearing in the bar when the output of
an ipc module is empty.
Adopt "keep a changelog" (#2308) * Adopt keep a changelog Ref: https://keepachangelog.com/en/1.0.0/ * Add changelog to release and contributing docs * Use H2 for automatically added Download section The individual changelog subsections use H3 and the changelog section uses H2, so the Download section should use the same heading * Add already present changes to changelog * Mention changelog issue references in CONTRIBUTING.md
2020-12-16 15:04:10 +00:00
New Tag Parser (#2303) * refactor(color): Use enum class for color type * Add testcases for tag parser * Make tag parser a pull-style parser Being able to parse single elements at a time gives us more fine-grained error messages, we can also parse as much as possible and only stop after an exception. * fix(color): Parser did not check for invalid chars * tag parser: First full implementation * tag parser: Fix remaining failing tests * tag parser: Replace old parser * tag parser: Treat alignment as formatting tag Makes the structure less complex and the alignment tags really are formatting tags, they are structurally no different from the %{R} tag. * tag parser: Cleanup type definitions All type definitions for tags now live in tags/types.hpp, the parser.hpp only contains the definitions necessary for actually calling the parser, this shouldn't be included in many places (only places that actually do parsing). But many places need the definitions for the tags themselves. * Rename components/parser to tags/dispatch * tag parser: Cleanup * Add changelog
2020-12-17 19:37:28 +00:00
### Fixed
script: Fix concurrency issues (#2518) Fixes #1978 * Move tail and non-tail handler to method Defining them in the constructor is ugly. * script: Iterate over defined actions instead of fixed list * Separate running logic and lock m_output * Include POLYBAR_FLAGS in linker flags * Stop using m_prev in script_runner * Join module threads in stop function Joining in the destructor may lead to UB because the subclass is already deconstructed but the threads may still require it to be around (e.g. for calling any functions on the instance) * Cleanup script module * Update changelog * Remove AfterReturn class * Remove m_stopping from script module * Fix polybar not reading the entire line from child process. For every `readline` call we created a new fd_streambuf. This means once `readline` returns, the streambuf is destructed and and pending data in its temporary buffer discarded and we never actually read it. * Remove unused includes
2021-10-02 23:27:11 +00:00
- `custom/script`: Concurrency issues with fast-updating tailed scripts.
([`#1978`](https://github.com/polybar/polybar/issues/1978))
xkeyboard: Fix indicator spacing (#2306) * Fix xkeyboard module spacing between the layout and indicators when indicators are empty. * Simplify the empty label check. * Remove permanently enabled SCROLL_LOCK, sorry. * Another mistake. * Update src/modules/xkeyboard.cpp Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com> * Update src/modules/xkeyboard.cpp Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com> * Update. * Fix xkeyboard module spacing between the layout and indicators, when indicators are empty. And fix the spacing between indicators when some are empty. * Add issue #2292 to fixed. * Update CHANGELOG.md Co-authored-by: Filip Banák <6111455-Filip62@users.noreply.gitlab.com> Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2020-12-17 19:49:10 +00:00
- Trailing space after the layout label when indicators are empty and made sure right amount
of spacing is added between the indicator labels, in the xkeyboard module.
([`#2292`](https://github.com/polybar/polybar/issues/2292))
New Tag Parser (#2303) * refactor(color): Use enum class for color type * Add testcases for tag parser * Make tag parser a pull-style parser Being able to parse single elements at a time gives us more fine-grained error messages, we can also parse as much as possible and only stop after an exception. * fix(color): Parser did not check for invalid chars * tag parser: First full implementation * tag parser: Fix remaining failing tests * tag parser: Replace old parser * tag parser: Treat alignment as formatting tag Makes the structure less complex and the alignment tags really are formatting tags, they are structurally no different from the %{R} tag. * tag parser: Cleanup type definitions All type definitions for tags now live in tags/types.hpp, the parser.hpp only contains the definitions necessary for actually calling the parser, this shouldn't be included in many places (only places that actually do parsing). But many places need the definitions for the tags themselves. * Rename components/parser to tags/dispatch * tag parser: Cleanup * Add changelog
2020-12-17 19:37:28 +00:00
- Parser error if click command contained `}`
([`#2040`](https://github.com/polybar/polybar/issues/2040))
fix: unbounded_percentage always rounded down For example if lower / upper = 0.019 (1.9%), it would return 1% instead of 2% Fixes #2399
2021-03-03 21:38:05 +00:00
- Slight imprecision when calculating percentages. This caused the volume
reported by alsa to be off by one.
([`#2399`](https://github.com/polybar/polybar/issues/2399))
feat(backlight): add use-actual-brightness option (#2380) * add use-actual-brightness option * added to changelog * added to changelog 2 * added to changelog 3
2021-02-16 09:02:33 +00:00
- `internal/backlight`: With amdgpu backlights, the brightness indicator was slightly behind.
Adding case to ignore T@ in bspwm (#2439) * Adding case to ignore T@ in bspwm * Adding entry to changelog for issue #2371
2021-05-27 18:05:37 +00:00
([`#2367`](https://github.com/polybar/polybar/issues/2367))
- Warning message regarding T@ in bspwm module
([`#2371`](https://github.com/polybar/polybar/issues/2371))
fix(monitor): do not include outputs when monitors are supported (#2485) * fix(monitor): do not include outputs when monitors are supported Previously, when splitting an output into two monitors, `polybar -m` would report both the splitted monitors and the output. This was not caught by the the clone detection as the detection works by removing monitors contained into another monitors (and monitors were excluded from that logic) and we want the other way around: outputs covered by monitors should be ignored. Instead of trying to detect covered outputs, the solution is quite simple: when monitors are supported, do not consider outputs, unless we request all outputs. A monitor can be set primary (and RandR reports primary outputs as primary monitors). The only information we would miss from monitors are things like refresh rate and EDID. We don't need that, so we are fine. As monitors are only created for connected output (and they are in this case "active") or disconnected output if they are mapped (and they are in this case "inactive"), I am a bit unsure if we have exactly the same behaviour as previously when `connected_only` is set to `false`. As some modules require an output, we keep the output in the `monitor_t` structure and we ensure it is correctly set when using monitors. A monitor can have 0 or several outputs. We only handle the 0 and 1 cases. When a monitor has more outputs, only the first one is used. AFAIK, only the xbacklight module needs that and I think we are fine waiting for a user needing this module and merging monitors. The C++ binding fail to expose the `outputs()` method to iterate over the outputs of a monitor. This seems to be a bug in XPP. The field is correctly defined in the RandR XML file and it works with the Python binding. ```xml <struct name="MonitorInfo"> <field type="ATOM" name="name" /> <field type="BOOL" name="primary" /> <field type="BOOL" name="automatic" /> <field type="CARD16" name="nOutput" /> <field type="INT16" name="x" /> <field type="INT16" name="y" /> <field type="CARD16" name="width" /> <!-- pixels --> <field type="CARD16" name="height" /> <!-- pixels --> <field type="CARD32" name="width_in_millimeters" /> <field type="CARD32" name="height_in_millimeters" /> <list type="OUTPUT" name="outputs"> <fieldref>nOutput</fieldref> </list> </struct> ``` Falling back to C only to access the list of outputs is not enough because the list is appended to the structure and not visible through the public API. When copied, the structure loses the list of monitors. Also, change the mention "XRandR monitor" to "no output" when there is no output attached. People using monitors know what it means and it is useful to catch a future regression where we don't have an output at all (which would break the brightness plugin). Fix #2481 * Update CHANGELOG.md Co-authored-by: Patrick Ziegler <p.ziegler96@gmail.com>
2021-09-02 16:07:21 +00:00
- `polybar -m` used to show both physical outputs and randr monitors, even if the outputs were covered by monitors.
([`#2481`](https://github.com/polybar/polybar/issues/2481))
The xworkspaces module should wait for EWMH to become available (#2429) * The xworkspaces module should wait for EWMH to become available Before this change if EWMH wasn't available the xworkspaces module was permanently disabled. When polybar was started alongside the window manager e.g. from .xinitrc this caused a race condition between polybar and the window manager and the xworkspaces module may or may not be displayed. After this change polybar will wait for EWMH to become available. This change closes #1915, see that issue for more details. Curiously this only required the removal of the error condition which used the be raised when EWMH wasn't available. The xworkspaces module will show up on the bar as soon as the first EWMH event is processed by the existing event handling code. I can't argue much about the correctness of this patch but it seems to work flawlessly in my testing with xmonad. I didn't test any other window managers. Note that removing the error condition below which checks that _NET_DESKTOP_VIEWPORT is available might make this work with pin-workspaces=true. I couldn't test the effects of that change because I only tested with xmonad and xmonad doesn't support _NET_DESKTOP_VIEWPORT, so I didn't make that change. * xworkspaces: Remove check fo _NET_DESKTOP_VIEWPORT Implementations that don't support it will just return an empty list for get_desktop_viewports and pin-workspaces won't do anything. * Update changelog Fixes #1915 Co-authored-by: Tim Schumacher <tim@timakro.de> Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2021-10-11 12:40:14 +00:00
- `internal/xworkspaces`:
- Broken scroll-wrapping and order of workspaces when scrolling
([`#2491`](https://github.com/polybar/polybar/issues/2491))
- Module would error if WM was not full started up.
([`#1915`](https://github.com/polybar/polybar/issues/1915))
fix(net): Use canonical interface name (#2540) One can define an 'altname' for an interface. That name is valid of if_nametoindex but it doesn't appear in `/sys/class/net`: ``` sudo ip link property add dev enp0s31f6 altname eno ``` This creates an altname eno for the existing interface enp0s31f6 Before, using eno, would lead to an error in `realpath`. Ref: https://www.reddit.com/r/Polybar/comments/q8f0ye/error_disabling_module_network_reason_realpath/hgqpq1m/?context=3
2021-10-15 15:36:32 +00:00
- `internal/network`: The module now properly supports 'altnames' for
interfaces.
fix(battery): More accurate battery state (#2556) Fixes #2563 Closes #2363 * Get battery status before adapter. (#2363) * changelog: Move to Fixed section Co-authored-by: patrick96 <p.ziegler96@gmail.com>
2022-01-17 22:07:07 +00:00
- `internal/battery`: More accurate battery state
([`#2563`](https://github.com/polybar/polybar/issues/2563))
Replace system_clock with steady_clock (#2559) This fixes #857 and #1932. Also replaces PR #1725, since we don't need our own implementation of condition_variable anymore since people who update their polybar should have GCC 10 by now. The m_updated_at field of the mpd module was removed instead of having its clock change because it became unused in commit 645a3142a19747c252d24cc71414d40a8eb5f7dc.
2022-01-12 22:06:29 +00:00
- Some modules stop updating when system time moves backwards. ([`#857`](https://github.com/polybar/polybar/issues/857), [`#1932`](https://github.com/polybar/polybar/issues/1932))
fix(xworkspaces): Fix scrolling (#2492) The scroll handler had two issues: * It did not respect the order the desktops where displayed in * It would not wrap around on the first desktop because of an integer underflow Fixes #2491
2021-09-04 12:36:01 +00:00
Release 3.5.7
2021-09-21 16:12:57 +00:00
## [3.5.7] - 2021-09-21
tray: Properly handle missing _XEMBED_INFO The icon not supporting XEMBED is not fatal, we just treat is as always mapped. Fixes #2479 Fixes #2442
2021-09-08 16:13:21 +00:00
### Fixed
- The tray mistakenly removed tray icons that did not support XEMBED
([`#2479`](https://github.com/polybar/polybar/issues/2479),
[`#2442`](https://github.com/polybar/polybar/issues/2442))
fix(ipc): Replace all %pid% tokens Fixes #2500
2021-09-13 12:06:08 +00:00
- `custom/ipc`: Only the first appearance of the `%pid%` token was replaced
([`#2500`](https://github.com/polybar/polybar/issues/2500))
New Tag Parser (#2303) * refactor(color): Use enum class for color type * Add testcases for tag parser * Make tag parser a pull-style parser Being able to parse single elements at a time gives us more fine-grained error messages, we can also parse as much as possible and only stop after an exception. * fix(color): Parser did not check for invalid chars * tag parser: First full implementation * tag parser: Fix remaining failing tests * tag parser: Replace old parser * tag parser: Treat alignment as formatting tag Makes the structure less complex and the alignment tags really are formatting tags, they are structurally no different from the %{R} tag. * tag parser: Cleanup type definitions All type definitions for tags now live in tags/types.hpp, the parser.hpp only contains the definitions necessary for actually calling the parser, this shouldn't be included in many places (only places that actually do parsing). But many places need the definitions for the tags themselves. * Rename components/parser to tags/dispatch * tag parser: Cleanup * Add changelog
2020-12-17 19:37:28 +00:00
Release 3.5.6
2021-05-23 23:00:50 +00:00
## [3.5.6] - 2021-05-24
fix(build): Disable sphinx manpage section dirs Before sphinx 4.0, this was the default but was changed in 4.0. Now by default the folder structure looks like this: man ├── 1 │   └── polybar.1 └── 5 └── polybar.5 This restores the old behavior where there weren't individual folders for the different sections. Fixes #2424 Ref: https://www.sphinx-doc.org/en/master/changes.html#id14
2021-05-09 19:19:15 +00:00
### Build
- Support building documentation on sphinx 4.0 ([`#2424`](https://github.com/polybar/polybar/issues/2424))
fix(tray): Support clients with different depths XCB_BACK_PIXMAP_PARENT_RELATIVE requires that the client has the same depth as the tray window. There was an issue with dropbox having a depth of 32 and the tray window having a depth of 24 that caused the configuration of the icon to fail. It would then be displayed outside of the bar because the catch block was not hit (different exception). We now just don't configure XCB_CW_BACK_PIXMAP. This seems to work and is also what stalonetray does. This does not fix the issue with dropbox having an arbitrary background. Fixes #1679 Fixes #2430
2021-05-18 09:02:10 +00:00
### Fixed
- Tray icons sometimes appears outside of bar ([`#2430`](https://github.com/polybar/polybar/issues/2430), [`#1679`](https://github.com/polybar/polybar/issues/1679))
Fix i3 module assertion failure This brings #2417 into the hotfix release Ref #2417
2021-05-23 22:51:18 +00:00
- Crash in the i3 module ([`#2416`](https://github.com/polybar/polybar/issues/2416))
fix(build): Disable sphinx manpage section dirs Before sphinx 4.0, this was the default but was changed in 4.0. Now by default the folder structure looks like this: man ├── 1 │   └── polybar.1 └── 5 └── polybar.5 This restores the old behavior where there weren't individual folders for the different sections. Fixes #2424 Ref: https://www.sphinx-doc.org/en/master/changes.html#id14
2021-05-09 19:19:15 +00:00
Release 3.5.5
2021-03-01 20:33:03 +00:00
## [3.5.5] - 2021-03-01
fix(build): Only change VersionDirective if supported The VersionChange class is not available in older versions of sphinx, so we just disable it Fixes #2356
2021-01-19 09:42:27 +00:00
### Build
- Support older python sphinx versions again ([`#2356`](https://github.com/polybar/polybar/issues/2356))
Release 3.5.4
2021-01-07 12:44:30 +00:00
## [3.5.4] - 2021-01-07
Remove tag compaction "optimizations" The intention was to remove tags that won't have an effect and join together consecutive tags. However the patterns used can just as well appear in regular text, so this can replace characters inside user defined text and not just formatting tags. Fixes #2331
2020-12-24 22:52:35 +00:00
### Fixed
- Wrong text displayed if module text ends with `}` ([`#2331`](https://github.com/polybar/polybar/issues/2331))
Release 3.5.3
2020-12-23 16:32:15 +00:00
## [3.5.3] - 2020-12-23
### Build
Remove tag compaction "optimizations" The intention was to remove tags that won't have an effect and join together consecutive tags. However the patterns used can just as well appear in regular text, so this can replace characters inside user defined text and not just formatting tags. Fixes #2331
2020-12-24 22:52:35 +00:00
- Don't use `git` when building documentation ([`#2309`](https://github.com/polybar/polybar/issues/2309))
Release 3.5.3
2020-12-23 16:32:15 +00:00
### Fixed
- Empty color values are no longer treated as invalid and no longer produce an error.
Release 3.5.7
2021-09-21 16:12:57 +00:00
[Unreleased]: https://github.com/polybar/polybar/compare/3.5.7...HEAD
[3.5.7]: https://github.com/polybar/polybar/releases/tag/3.5.7
Merge branch 'hotfix/3.5.6'
2021-05-23 23:07:24 +00:00
[3.5.6]: https://github.com/polybar/polybar/releases/tag/3.5.6
Release 3.5.5
2021-03-01 20:33:03 +00:00
[3.5.5]: https://github.com/polybar/polybar/releases/tag/3.5.5
Release 3.5.4
2021-01-07 12:44:30 +00:00
[3.5.4]: https://github.com/polybar/polybar/releases/tag/3.5.4
cmake: Add option to enable/disable sample config
2020-12-23 23:56:31 +00:00
[3.5.3]: https://github.com/polybar/polybar/releases/tag/3.5.3