From 94e1c64dff527c46c6f8d6ba25df9f28d7d56898 Mon Sep 17 00:00:00 2001
From: patrick96
Date: Sun, 13 Dec 2020 15:24:31 +0100
Subject: [PATCH 1/2] fix: Module type always empty string
The change in #2270 accidentally broke how we access module types.
module::TYPE always points to the module superclass and it thus
accesses its empty TYPE field.
This mainly broke legacy action handling.
Ref #2270
---
include/modules/meta/base.hpp | 2 --
include/modules/meta/base.inl | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/modules/meta/base.hpp b/include/modules/meta/base.hpp
index 9d776c97..420ff52a 100644
--- a/include/modules/meta/base.hpp
+++ b/include/modules/meta/base.hpp
@@ -148,8 +148,6 @@ namespace modules {
bool input(const string& action, const string& data);
- static constexpr auto TYPE = "";
-
protected:
void broadcast();
void idle();
diff --git a/include/modules/meta/base.inl b/include/modules/meta/base.inl
index 6792c02f..c6f0fdb4 100644
--- a/include/modules/meta/base.inl
+++ b/include/modules/meta/base.inl
@@ -48,7 +48,7 @@ namespace modules {
template
string module::type() const {
- return string(module::TYPE);
+ return string(Impl::TYPE);
}
template
From 3eda8832b9fc305265b062939336f94b19d7159c Mon Sep 17 00:00:00 2001
From: patrick96
Date: Mon, 14 Dec 2020 10:45:29 +0100
Subject: [PATCH 2/2] Release 3.5.2
Changelog
**Fixes**
Legacy action name support was accidentally broken in 3.5.1 (#2296), see #2299
---
version.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/version.txt b/version.txt
index 161ce030..2bd23581 100644
--- a/version.txt
+++ b/version.txt
@@ -1,4 +1,4 @@
# Polybar version information
# Update this on every release
# This is used to create the version string if a git repo is not available
-3.5.1
+3.5.2