diff --git a/.clang-tidy b/.clang-tidy index d28a1322..a763ee6d 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -32,20 +32,15 @@ Checks: ' ' CheckOptions: - - key: modernize-loop-convert.NamingStyle - value: lower_case - - key: readability-identifier-naming.ClassCase - value: lower_case - - key: readability-identifier-naming.ClassConstantCase - value: UPPER_CASE - - key: readability-identifier-naming.ClassMethodCase - value: lower_case - - key: readability-identifier-naming.MemberCase - value: lower_case - - key: readability-identifier-naming.ProtectedMemberPrefix - value: 'm_' - - key: readability-identifier-naming.PrivateMemberPrefix - value: 'm_' + cppcoreguidelines-avoid-do-while.IgnoreMacros: true + modernize-loop-convert.NamingStyle: lower_case + readability-identifier-naming.ClassCase: lower_case + readability-identifier-naming.ClassConstantCase: UPPER_CASE + readability-identifier-naming.ClassMethodCase: lower_case + readability-identifier-naming.MemberCase: lower_case + readability-identifier-naming.ProtectedMemberPrefix: 'm_' + readability-identifier-naming.PrivateMemberPrefix: 'm_' + HeaderFilterRegex: '' WarningsAsErrors: '' AnalyzeTemporaryDtors: false diff --git a/CHANGELOG.md b/CHANGELOG.md index c4050623..519fef59 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Fixed - Token min-length calculations would behave differently when non-ASCII characters appear in the token ([`#3074`](https://github.com/polybar/polybar/issues/3074), [`#3087`](https://github.com/polybar/polybar/pull/3087)) by [@nklloyd](https://github.com/nklloyd) +- i3: Fix duplicated rendering for non-full-width bars ([`#3091`](https://github.com/polybar/polybar/pull/3091), [`#3060`](https://github.com/polybar/polybar/issues/3060)) - `internal/backlight`: Module could display the literal `%percentage%` token if the backlight reports a value of 0 at startup ([`#3081`](https://github.com/polybar/polybar/pull/3081)) by [@unclechu](https://github.com/unclechu) ## [3.7.1] - 2023-11-27 diff --git a/src/components/renderer.cpp b/src/components/renderer.cpp index fbedb8d6..8b5c75c4 100644 --- a/src/components/renderer.cpp +++ b/src/components/renderer.cpp @@ -86,14 +86,6 @@ renderer::renderer(connection& conn, signal_emitter& sig, const config& conf, co { m_pixmap = m_connection.generate_id(); m_connection.create_pixmap(m_depth, m_pixmap, m_window, m_bar.size.w, m_bar.size.h); - - uint32_t configure_mask = 0; - std::array configure_values{}; - xcb_params_cw_t configure_params{}; - - XCB_AUX_ADD_PARAM(&configure_mask, &configure_params, back_pixmap, m_pixmap); - connection::pack_values(configure_mask, &configure_params, configure_values); - m_connection.change_window_attributes_checked(m_window, configure_mask, configure_values.data()); } m_log.trace("renderer: Allocate graphic contexts"); @@ -372,8 +364,8 @@ void renderer::flush() { highlight_clickable_areas(); m_surface->flush(); - // Clear entire window so that the new pixmap is shown - m_connection.clear_area(0, m_window, 0, 0, m_bar.size.w, m_bar.size.h); + // Copy pixmap onto the window + m_connection.copy_area(m_pixmap, m_window, m_gcontext, 0, 0, 0, 0, m_bar.size.w, m_bar.size.h); m_connection.flush(); if (!m_snapshot_dst.empty()) {