1
0
Fork 0
mirror of https://github.com/polybar/polybar.git synced 2024-10-27 05:23:39 -04:00
polybar/include/x11
Jeremy Fleischman f488a889bc
Add support for a tray-foreground setting. (#2552)
This adds a new `tray-foreground` config option, and uses it instead of
the `tray-background` setting to build up the `_NET_SYSTEM_TRAY_COLORS`
property. I'm pretty sure that the previous behavior was a mistake (this
was introduced in 94298741b6 which is a
pretty large diff).  For me and some other people, this results in a
black icon being drawn on top of a black background, which is pretty
useless! I would say that this diff fixes
https://github.com/polybar/polybar/issues/2235. Note: the old code dealt
with `unsigned int` and maxed values out at 0xff. The new code deals
with `uint16_t` and maxes values out at 0xffff. I haven't found the
relevant documentation to justify this change, but from manually
testing, I'm pretty confident this is the right change.

This all matches pretty closely with this code from i3:
[`i3bar/src/xcb.c::init_tray_colors`
code](43e805a00d/i3bar/src/xcb.c (L1490-L1522)),
which you can see also uses the bar's foreground color and maxes values
out at 0xffff, not 0xff.

If you merge this up, I think we should also update
https://github.com/polybar/polybar/wiki/Configuration#bar-settings to
mention the new settings.

Fixes #2235
2021-11-17 11:41:40 +01:00
..
extensions fix(x11): Don't include composite when disabled 2020-12-22 00:37:07 +01:00
atoms.hpp fix(renderer): Handling of missing root pixmap (#1608) 2019-01-17 14:22:48 +01:00
background_manager.hpp Move update events to eventloop 2021-09-21 20:36:23 +02:00
connection.hpp Add compiler warning for missing override specifier (#2341) 2021-01-04 10:38:43 +01:00
cursor.hpp fix(compiling): map variable without namespace. (#1395) 2018-08-24 13:37:45 +02:00
ewmh.hpp fix(xworkspace): Fully support _NET_DESKTOP_NAMES spec (#1579) 2019-02-08 13:32:31 +01:00
icccm.hpp feat(xworkspaces): add urgent desktop detection 2017-02-23 13:20:26 +01:00
registry.hpp
tray_client.hpp tray: Properly handle missing _XEMBED_INFO 2021-09-13 00:12:33 +02:00
tray_manager.hpp Add support for a tray-foreground setting. (#2552) 2021-11-17 11:41:40 +01:00
types.hpp
window.hpp fix(window): remove useless operator= and add default copy cstr (#1729) 2019-04-07 17:32:55 +02:00
winspec.hpp doc: Convert @ to \ doxygen commands 2018-11-04 19:28:27 -08:00
xembed.hpp tray: Properly handle missing _XEMBED_INFO 2021-09-13 00:12:33 +02:00
xresources.hpp Remove undefined behaviors and clean code (#1769) 2021-02-15 23:32:56 +01:00