1
0
Fork 0
mirror of https://github.com/polybar/polybar.git synced 2024-11-11 13:50:56 -05:00
polybar/include
Jeremy Fleischman f488a889bc
Add support for a tray-foreground setting. (#2552)
This adds a new `tray-foreground` config option, and uses it instead of
the `tray-background` setting to build up the `_NET_SYSTEM_TRAY_COLORS`
property. I'm pretty sure that the previous behavior was a mistake (this
was introduced in 94298741b6 which is a
pretty large diff).  For me and some other people, this results in a
black icon being drawn on top of a black background, which is pretty
useless! I would say that this diff fixes
https://github.com/polybar/polybar/issues/2235. Note: the old code dealt
with `unsigned int` and maxed values out at 0xff. The new code deals
with `uint16_t` and maxes values out at 0xffff. I haven't found the
relevant documentation to justify this change, but from manually
testing, I'm pretty confident this is the right change.

This all matches pretty closely with this code from i3:
[`i3bar/src/xcb.c::init_tray_colors`
code](43e805a00d/i3bar/src/xcb.c (L1490-L1522)),
which you can see also uses the bar's foreground color and maxes values
out at 0xffff, not 0xff.

If you merge this up, I think we should also update
https://github.com/polybar/polybar/wiki/Configuration#bar-settings to
mention the new settings.

Fixes #2235
2021-11-17 11:41:40 +01:00
..
adapters fix(net): Use canonical interface name (#2540) 2021-10-15 17:36:32 +02:00
cairo Fixed issues with border corner radii 2021-03-29 20:17:48 +02:00
components Allow running polybar without BAR argument (#2526) 2021-10-07 14:48:47 +02:00
drawtypes feat(xkeyboard): Icon matching using variant (#2521) 2021-10-05 12:12:47 +02:00
events Integrate bar taskqueue into eventloop (#2510) 2021-09-27 17:35:45 +02:00
modules ipc: Move running initial hook to update function (#2547) 2021-10-30 21:00:52 +02:00
tags fix typos (#2524) 2021-10-04 23:46:38 +02:00
utils feat: Support reading config from non-regular files (#2545) 2021-10-24 11:25:05 +02:00
x11 Add support for a tray-foreground setting. (#2552) 2021-11-17 11:41:40 +01:00
CMakeLists.txt refactor(cmake): Allow targets to be enabled individually 2020-12-24 02:20:38 +01:00
common.hpp refactor(build): Remove version number namespace 2019-05-17 16:49:47 +02:00
debug.hpp refactor: Cleanup 2017-01-11 03:07:28 +01:00
errors.hpp Add missing <stdexcept> header 2019-12-25 01:00:29 +01:00
settings.hpp.cmake Integrate bar taskqueue into eventloop (#2510) 2021-09-27 17:35:45 +02:00