diff --git a/doc/rofi-manpage.markdown b/doc/rofi-manpage.markdown index 610f0664..e585fc08 100644 --- a/doc/rofi-manpage.markdown +++ b/doc/rofi-manpage.markdown @@ -318,6 +318,8 @@ Rofi supports the following keybindings: **rofi** website can be found at [here](https://davedavenport.github.io/rofi/) +**rofi** bugtracker can be found [here](https://github.com/DaveDavenport/rofi/issues) + ## AUTHOR Qball Cow diff --git a/doc/rofi.1 b/doc/rofi.1 index a901cc3f..6b88401f 100644 --- a/doc/rofi.1 +++ b/doc/rofi.1 @@ -422,6 +422,10 @@ Rofi supports the following keybindings: \fBrofi\fP website can be found at here .UR https://davedavenport.github.io/rofi/ .UE +.PP +\fBrofi\fP bugtracker can be found here +.UR https://github.com/DaveDavenport/rofi/issues +.UE .SH AUTHOR .PP Qball Cow diff --git a/source/helper.c b/source/helper.c index 9ae556ab..4b1194d3 100644 --- a/source/helper.c +++ b/source/helper.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -64,6 +65,8 @@ int helper_parse_setup ( char * string, char ***output, int *length, ... ) error->message ); #ifdef error_dialog error_dialog ( msg ); +#else + fputs ( msg, stderr ); #endif g_free ( msg ); // print error. diff --git a/source/rofi.c b/source/rofi.c index 95b88f95..3aee8e97 100644 --- a/source/rofi.c +++ b/source/rofi.c @@ -1553,7 +1553,7 @@ MenuReturn menu ( char **lines, unsigned int num_lines, char **input, char *prom if ( state.selected_line != NULL ) { // The cast to unsigned in here is valid, we checked if selected_line > 0. // So its maximum range is 0-2³¹, well within the num_lines range. - if ( *( state.selected_line ) >= 0 && (unsigned int) ( *( state.selected_line ) ) <= state.num_lines ) { + if ( (*( state.selected_line )) >= 0 && (unsigned int) ( *( state.selected_line ) ) <= state.num_lines ) { state.selected = *( state.selected_line ); } } diff --git a/source/script-dialog.c b/source/script-dialog.c index b4dca016..efde4caf 100644 --- a/source/script-dialog.c +++ b/source/script-dialog.c @@ -73,7 +73,6 @@ pid_t execute_generator ( char * cmd ) static char **get_script_output ( char *command, unsigned int *length ) { - char buffer[1024]; char **retv = NULL; *length = 0; @@ -81,6 +80,7 @@ static char **get_script_output ( char *command, unsigned int *length ) if ( fd >= 0 ) { FILE *inp = fdopen ( fd, "r" ); if ( inp ) { + char buffer[1024]; while ( fgets ( buffer, 1024, inp ) != NULL ) { retv = g_realloc ( retv, ( ( *length ) + 2 ) * sizeof ( char* ) ); retv[( *length )] = g_strdup ( buffer );