PolytreeDE
/
rofi
mirror of https://github.com/davatorium/rofi.git
1
0
Fork 0
Code Releases Activity

[View] Work around GThreadPool 1 pointer bug. 

* Also fix typo in icon fetcher.
This commit is contained in:
Dave Davenport 2024-03-08 09:38:15 +01:00
parent 0bf0c51827
commit af6fb83a51
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
source/rofi-icon-fetcher.c
View File

@ -94,7 +94,7 @@ static void rofi_icon_fetch_entry_free(gpointer data);
IconFetcher *rofi_icon_fetcher_data = NULL;
static void rofi_icon_fetch_thread_pool_entry_remove(gpointer data) {
IconFetcherNameEntry *entry = (IconFetcherNameEntry *)data;
IconFetcherEntry *entry = (IconFetcherEntry *)data;
// Mark it in a way it should be re-fetched on next query?
}
static void rofi_icon_fetch_entry_free(gpointer data) {

9
source/view.c
View File

@ -2653,6 +2653,15 @@ static int rofi_thread_workers_sort(gconstpointer a, gconstpointer b,
static void rofi_thread_pool_state_free(gpointer data) {
if (data) {
// This is a weirdness from glib that should not happen.
// It pushes in a 1 to msg sleeping threads to wake up.
// This should be removed from queue to avoid hitting this method.
// In practice, we still hit it (and crash)
if (GPOINTER_TO_UINT(data) == 1) {
// Ignore this entry.
g_debug("Glib thread-pool bug, received pointer with value 1.");
return;
}
thread_state *ts = (thread_state *)data;
if (ts->free) {
ts->free(data);