PolytreeDE/rofi
1
0
Fork 0
mirror of https://github.com/davatorium/rofi.git synced 2025-11-06 22:54:53 -05:00
Code Releases Activity

[Script] fix missing and wrong free

Browse source
This commit is contained in:
Qball Cow 2025-10-07 23:04:35 +02:00
parent da898a728a
commit caa69c39d8
1 changed files with 17 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

33
source/modes/script.c
View file

@ -26,6 +26,7 @@
*/
/** The log domain of this dialog. */
#include "glib.h"
#define G_LOG_DOMAIN "Modes.Script"
#include "modes/script.h"
@ -343,6 +344,19 @@ static void script_mode_reset_highlight(Mode *sw) {
rmpd->active_list = NULL;
}
static void script_mode_free_entry_list (DmenuScriptEntry *list, unsigned int length )
{
for ( unsigned int i = 0; i < length; i++){
g_free(list[i].entry);
g_strfreev(list[i].icon_name);
g_free(list[i].display);
g_free(list[i].meta);
g_free(list[i].info);
}
g_free(list);
}
static ModeMode script_mode_result(Mode *sw, int mretv, char **input,
unsigned int selected_line) {
ScriptModePrivateData *rmpd = (ScriptModePrivateData *)sw->private_data;
@ -395,6 +409,7 @@ static ModeMode script_mode_result(Mode *sw, int mretv, char **input,
}
if (rmpd->switch_mode >= 0) {
script_mode_free_entry_list(new_list, new_length);
retv = rmpd->switch_mode;
free(*input);
*input = NULL;
@ -404,15 +419,7 @@ static ModeMode script_mode_result(Mode *sw, int mretv, char **input,
// If a new list was generated, use that an loop around.
if (new_list != NULL) {
for (unsigned int i = 0; i < rmpd->cmd_list_length; i++) {
g_free(rmpd->cmd_list[i].entry);
g_free(rmpd->cmd_list[i].icon_name);
g_free(rmpd->cmd_list[i].display);
g_free(rmpd->cmd_list[i].meta);
g_free(rmpd->cmd_list[i].info);
}
g_free(rmpd->cmd_list);
script_mode_free_entry_list(rmpd->cmd_list, rmpd->cmd_list_length);
rmpd->cmd_list = new_list;
rmpd->cmd_list_length = new_length;
if (keep_selection) {
@ -438,13 +445,7 @@ static ModeMode script_mode_result(Mode *sw, int mretv, char **input,
static void script_mode_destroy(Mode *sw) {
ScriptModePrivateData *rmpd = (ScriptModePrivateData *)sw->private_data;
if (rmpd != NULL) {
for (unsigned int i = 0; i < rmpd->cmd_list_length; i++) {
g_free(rmpd->cmd_list[i].entry);
g_strfreev(rmpd->cmd_list[i].icon_name);
g_free(rmpd->cmd_list[i].display);
g_free(rmpd->cmd_list[i].meta);
}
g_free(rmpd->cmd_list);
script_mode_free_entry_list(rmpd->cmd_list, rmpd->cmd_list_length);
g_free(rmpd->message);
g_free(rmpd->prompt);
g_free(rmpd->data);