* combi: Reuse own get_num_entries in self-init
* combi_mode_parse_switchers: Remove duplicated mode pointer
* combi_mode_parse_switchers: Regroup mode search lines
* combi_mode_result: Simplify switcher search quit
* mode_result: Check for mode switch actions before hook
These are over-mode actions, which should not be handled
in mode hooks at all.
* tests: initialize char* in mode test
Currently, test_mode_result relies on undefined behavior.
The test calls mode_result, which checks whether the pointer is NULL.
However, the pointer was never initialized, so it may or may not be
NULL, depending on the compiler.
This caused a test failure on ppc64 and Fedora 28, apparently because in
this setting, gcc sets uninitialized pointers to NULL.
By initializing the pointer to the empty string, the behavior is defined
and the test passes on all architectures.
* mode: fix input pointer check in mode_result
Do not check whether *input (i.e., the char* the input points to) is
NULL, as this is valid. Instead, check whether the input itself is NULL.
* tests: make char* input arg in test_mode_result modifiable
The function mode_result expects a modifiable char*, initialize the
argument properly so it can be modified.