forks/archivebox
1
0
Fork 0
Code Releases Activity

fix clicking add tag when no tag is selected throwing 500

Browse source
This commit is contained in:
Nick Sweeting 2021-03-01 01:39:06 -05:00
parent 76ff789164
commit 177d22da50
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
archivebox/core/admin.py
View file

@ -49,7 +49,6 @@ from django.contrib.admin.helpers import ActionForm
class SnapshotActionForm(ActionForm): class SnapshotActionForm(ActionForm):
tag = forms.ModelChoiceField(queryset=Tag.objects.all(), required=False) tag = forms.ModelChoiceField(queryset=Tag.objects.all(), required=False)
# pass
class SnapshotAdmin(SearchResultsAdminMixin, admin.ModelAdmin): class SnapshotAdmin(SearchResultsAdminMixin, admin.ModelAdmin):
@ -214,9 +213,10 @@ class SnapshotAdmin(SearchResultsAdminMixin, admin.ModelAdmin):
delete_snapshots.short_description = "Delete" delete_snapshots.short_description = "Delete"
def add_tag(self, request, queryset): def add_tag(self, request, queryset):
tag = request.POST['tag'] if tag and tag.id:
for obj in queryset: tag = request.POST['tag']
obj.tags.add(tag) for obj in queryset:
obj.tags.add(tag)
add_tag.short_description = "Add tag" add_tag.short_description = "Add tag"

4
archivebox/core/models.py
View file

@ -32,8 +32,8 @@ class Tag(models.Model):
""" """
Based on django-taggit model Based on django-taggit model
""" """
name = models.CharField(verbose_name="name", unique=True, blank=False, max_length=100) name = models.CharField(unique=True, blank=False, max_length=100)
slug = models.SlugField(verbose_name="slug", unique=True, blank=True, max_length=100) slug = models.SlugField(unique=True, blank=True, max_length=100)
class Meta: class Meta:
verbose_name = "Tag" verbose_name = "Tag"