forks/forgejo
1
0
Fork 0
Code Releases Activity

Disable all typographic replacements in markdown renderer (#11871)

Browse source 
* Disable all typographic replacements in markdown renderer

Previously we only disabled some of them. This disables all the default
replacements that goldmark's typographer extension offers, matching
GitHub's renderer.

Ref: https://github.com/yuin/goldmark#typographer-extension
Fixes: https://github.com/go-gitea/gitea/issues/11001

* remove typographer extension completely

* fix test

* really fix test

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
This commit is contained in:
silverwind 2020-06-13 08:10:17 +02:00 committed by GitHub
parent b6adf80a80
commit 2447ffc74a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/markup/html_test.go
View file

@ -208,7 +208,7 @@ func TestRender_email(t *testing.T) {
// Test that should *not* be turned into email links // Test that should *not* be turned into email links
test( test(
"\"info@gitea.com\"", "\"info@gitea.com\"",
`<p>“info@gitea.com”</p>`) `<p>&#34;info@gitea.com&#34;</p>`)
test( test(
"/home/gitea/mailstore/info@gitea/com", "/home/gitea/mailstore/info@gitea/com",
`<p>/home/gitea/mailstore/info@gitea/com</p>`) `<p>/home/gitea/mailstore/info@gitea/com</p>`)

7
modules/markup/markdown/markdown.go
View file

@ -49,13 +49,6 @@ func render(body []byte, urlPrefix string, metas map[string]string, wikiMarkdown
extension.TaskList, extension.TaskList,
extension.DefinitionList, extension.DefinitionList,
common.FootnoteExtension, common.FootnoteExtension,
extension.NewTypographer(
extension.WithTypographicSubstitutions(extension.TypographicSubstitutions{
extension.EnDash: nil,
extension.EmDash: nil,
extension.Ellipsis: nil,
}),
),
meta.Meta, meta.Meta,
), ),
goldmark.WithParserOptions( goldmark.WithParserOptions(