From 330b16642305458339d12222eea2ee9a1bbb3b64 Mon Sep 17 00:00:00 2001 From: wxiaoguang Date: Tue, 21 Feb 2023 04:44:32 +0800 Subject: [PATCH] Remove unnecessary and incorrect `find('.menu').toggle()` (#22987) Follows: * #22950 The dropdown menu works well without these codes. The reason is that the event bubbling still works for the dropdown menu, the Fomantic UI dropdown menu module will hide the menu correctly if an item is clicked. --- web_src/js/features/repo-issue.js | 2 -- web_src/js/features/repo-legacy.js | 2 -- 2 files changed, 4 deletions(-) diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js index 179ca9b726..7b8705ad2c 100644 --- a/web_src/js/features/repo-issue.js +++ b/web_src/js/features/repo-issue.js @@ -552,8 +552,6 @@ export function initRepoIssueReferenceIssue() { // Reference issue $(document).on('click', '.reference-issue', function (event) { const $this = $(this); - $this.closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line - const content = $(`#${$this.data('target')}`).text(); const poster = $this.data('poster-username'); const reference = $this.data('reference'); diff --git a/web_src/js/features/repo-legacy.js b/web_src/js/features/repo-legacy.js index e1dc514320..8178ed6547 100644 --- a/web_src/js/features/repo-legacy.js +++ b/web_src/js/features/repo-legacy.js @@ -291,7 +291,6 @@ export function initRepoCommentForm() { async function onEditContent(event) { event.preventDefault(); - $(this).closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line const $segment = $(this).closest('.header').next(); const $editContentZone = $segment.find('.edit-content-zone'); const $renderContent = $segment.find('.render-content'); @@ -584,7 +583,6 @@ function initRepoIssueCommentEdit() { // Quote reply $(document).on('click', '.quote-reply', function (event) { - $(this).closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line const target = $(this).data('target'); const quote = $(`#${target}`).text().replace(/\n/g, '\n> '); const content = `> ${quote}\n\n`;