forks/forgejo
1
0
Fork 0
Code Releases Activity

Fix branch page pull request title and link error (#10092)

Browse source 
* Fix branch page pull request title and link error

* Fix ui
This commit is contained in:
Lunny Xiao 2020-02-01 21:54:25 +08:00 committed by GitHub
parent 107a694fd6
commit 3ccd271081
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
routers/repo/branch.go
View file

@ -239,6 +239,7 @@ func loadBranches(ctx *context.Context) []*Branch {
} else { } else {
repoIDToRepo[pr.BaseRepoID] = pr.BaseRepo repoIDToRepo[pr.BaseRepoID] = pr.BaseRepo
} }
pr.Issue.Repo = pr.BaseRepo
if pr.HasMerged { if pr.HasMerged {
baseGitRepo, ok := repoIDToGitRepo[pr.BaseRepoID] baseGitRepo, ok := repoIDToGitRepo[pr.BaseRepoID]
@ -261,7 +262,6 @@ func loadBranches(ctx *context.Context) []*Branch {
mergeMovedOn = true mergeMovedOn = true
} }
} }
} }
isIncluded := divergence.Ahead == 0 && ctx.Repo.Repository.DefaultBranch != branchName isIncluded := divergence.Ahead == 0 && ctx.Repo.Repository.DefaultBranch != branchName

10
templates/repo/branch/list.tmpl
View file

@ -73,7 +73,7 @@
</div> </div>
{{end}} {{end}}
</td> </td>
<td class="two wide right aligned"> <td class="three wide right aligned">
{{if not .LatestPullRequest}} {{if not .LatestPullRequest}}
{{if .IsIncluded}} {{if .IsIncluded}}
<a class="ui poping up orange small label" data-content="{{$.i18n.Tr "repo.branch.included_desc"}}" data-variation="tiny inverted" data-position="top right"> <a class="ui poping up orange small label" data-content="{{$.i18n.Tr "repo.branch.included_desc"}}" data-variation="tiny inverted" data-position="top right">
@ -91,13 +91,13 @@
</a> </a>
{{end}} {{end}}
{{else}} {{else}}
<a href="{{$.RepoLink}}/pulls/{{.LatestPullRequest.Issue.Index}}">#{{.LatestPullRequest.Issue.Index}}</a> <a href="{{.LatestPullRequest.Issue.HTMLURL}}">{{if not .LatestPullRequest.IsSameRepo}}{{.LatestPullRequest.BaseRepo.FullName}}{{end}}#{{.LatestPullRequest.Issue.Index}}</a>
{{if .LatestPullRequest.HasMerged}} {{if .LatestPullRequest.HasMerged}}
<a href="{{$.RepoLink}}/pulls/{{.LatestPullRequest.Issue.Index}}" class="ui purple small label"><i class="octicon octicon-git-pull-request"></i> {{$.i18n.Tr "repo.pulls.merged"}}</a> <a href="{{.LatestPullRequest.Issue.HTMLURL}}" class="ui purple mini label"><i class="octicon octicon-git-pull-request"></i> {{$.i18n.Tr "repo.pulls.merged"}}</a>
{{else if .LatestPullRequest.Issue.IsClosed}} {{else if .LatestPullRequest.Issue.IsClosed}}
<a href="{{$.RepoLink}}/pulls/{{.LatestPullRequest.Issue.Index}}" class="ui red small label"><i class="octicon octicon-issue-closed"></i> {{$.i18n.Tr "repo.issues.closed_title"}}</a> <a href="{{.LatestPullRequest.Issue.HTMLURL}}" class="ui red mini label"><i class="octicon octicon-issue-closed"></i> {{$.i18n.Tr "repo.issues.closed_title"}}</a>
{{else}} {{else}}
<a href="{{$.RepoLink}}/pulls/{{.LatestPullRequest.Issue.Index}}" class="ui green small label"><i class="octicon octicon-issue-opened"></i> {{$.i18n.Tr "repo.issues.open_title"}}</a> <a href="{{.LatestPullRequest.Issue.HTMLURL}}" class="ui green mini label"><i class="octicon octicon-issue-opened"></i> {{$.i18n.Tr "repo.issues.open_title"}}</a>
{{end}} {{end}}
{{end}} {{end}}
</td> </td>