forks/forgejo
1
0
Fork 0
Code Releases Activity

Fix loading button with invalid form (#20754)

Browse source 
Previously, if a invalid form was submitted (for example issue with no
title), the form could not be re-submitted again because the button
would not stay stuck in loading state. Fix that by hooking the 'submit'
event instead which triggers only when the form is valid.

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
silverwind 2022-08-11 05:54:34 +02:00 committed by GitHub
parent 54d9816502
commit 57f1ea0366
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
web_src/js/features/common-global.js
View file

@ -142,16 +142,12 @@ export function initGlobalCommon() {
} }
}); });
// loading-button this logic used to prevent push one form more than one time // prevent multiple form submissions on forms containing .loading-button
$(document).on('click', '.button.loading-button', function (e) { document.addEventListener('submit', (e) => {
const $btn = $(this); const btn = e.target.querySelector('.loading-button');
if (!btn) return;
if ($btn.hasClass('loading')) { if (btn.classList.contains('loading')) return e.preventDefault();
e.preventDefault(); btn.classList.add('loading');
return false;
}
$btn.addClass('loading disabled');
}); });
} }