1
0
Fork 0

[UI] Fix misalligned icons

- On the pull request page, two icons were misaligned vertically with
their text part.
- This patch adds the simple flexbox trick with `align-items: center` to
vertically center the children elements and adds `gt-ml-2` to the text,
to add space between icon and text that would otherwise be removed
because of `display: flex`.
This commit is contained in:
Gusted 2023-06-08 14:22:52 +02:00
parent f43e9fc4fd
commit 5c991c1043
No known key found for this signature in database
GPG key ID: FD821B732837125F
2 changed files with 5 additions and 5 deletions

View file

@ -1,9 +1,9 @@
{{if and (gt $.Issue.PullRequest.CommitsBehind 0) (not $.Issue.IsClosed) (not $.Issue.PullRequest.IsChecking) (not $.IsPullFilesConflicted) (not $.IsPullRequestBroken)}}
<div class="ui divider"></div>
<div class="item item-section">
<div class="item-section-left">
<i class="icon icon-octicon">{{svg "octicon-alert"}}</i>
{{$.locale.Tr "repo.pulls.outdated_with_base_branch"}}
<div class="item-section-left gt-df gt-ac">
<i class="icon icon-octicon gt-df gt-ac">{{svg "octicon-alert"}}</i>
<span class="gt-ml-2">{{$.locale.Tr "repo.pulls.outdated_with_base_branch"}}</span>
</div>
<div class="item-section-right">
{{if and $.UpdateAllowed $.UpdateByRebaseAllowed}}

View file

@ -63,9 +63,9 @@
<div v-if="!showActionForm" class="gt-df">
<!-- the merge button -->
<div class="ui buttons merge-button" :class="[mergeForm.emptyCommit ? 'grey' : mergeForm.allOverridableChecksOk ? 'green' : 'red']" @click="toggleActionForm(true)">
<button class="ui button">
<button class="ui button gt-df gt-ac">
<svg-icon name="octicon-git-merge"/>
<span class="button-text">
<span class="button-text gt-ml-2">
{{ mergeStyleDetail.textDoMerge }}
<template v-if="autoMergeWhenSucceed">
{{ mergeForm.textAutoMergeButtonWhenSucceed }}