forks/forgejo
1
0
Fork 0
Code Releases Activity

Scoped labels: don't require holding alt key to remove (#23303)

Browse source 
Alt doesn't work on all browsers, the simplest solution for v1.19 is to
just not require it and toggle the label by just clicking.

Part of #22974

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
This commit is contained in:
Brecht Van Lommel 2023-03-06 11:20:29 +01:00 committed by GitHub
parent e0800133dc
commit 68d7d772eb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
web_src/js/features/repo-legacy.js
View file

@ -145,7 +145,6 @@ export function initRepoCommentForm() {
const clickedItem = $(this); const clickedItem = $(this);
const scope = $(this).attr('data-scope'); const scope = $(this).attr('data-scope');
const canRemoveScope = e.altKey;
$(this).parent().find('.item').each(function () { $(this).parent().find('.item').each(function () {
if (scope) { if (scope) {
@ -153,11 +152,7 @@ export function initRepoCommentForm() {
if ($(this).attr('data-scope') !== scope) { if ($(this).attr('data-scope') !== scope) {
return true; return true;
} }
if ($(this).is(clickedItem)) { if (!$(this).is(clickedItem) && !$(this).hasClass('checked')) {
if (!canRemoveScope && $(this).hasClass('checked')) {
return true;
}
} else if (!$(this).hasClass('checked')) {
return true; return true;
} }
} else if (!$(this).is(clickedItem)) { } else if (!$(this).is(clickedItem)) {