forks/forgejo
1
0
Fork 0
Code Releases Activity

Correctly handle draft releases without a tag (#20314)

Browse source 
Fixes #20313.

`errors.Is(err, git.ErrNotExist{})` is not working
This commit is contained in:
Chongyi Zheng 2022-07-12 08:57:38 -04:00 committed by GitHub
parent 3aec32ad16
commit 966e7bdc9b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
services/migrations/gitea_uploader.go
View file

@ -7,7 +7,6 @@ package migrations
import ( import (
"context" "context"
"errors"
"fmt" "fmt"
"io" "io"
"os" "os"
@ -268,7 +267,7 @@ func (g *GiteaLocalUploader) CreateReleases(releases ...*base.Release) error {
// calc NumCommits if possible // calc NumCommits if possible
if rel.TagName != "" { if rel.TagName != "" {
commit, err := g.gitRepo.GetTagCommit(rel.TagName) commit, err := g.gitRepo.GetTagCommit(rel.TagName)
if !errors.Is(err, git.ErrNotExist{}) { if !git.IsErrNotExist(err) {
if err != nil { if err != nil {
return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err) return fmt.Errorf("GetTagCommit[%v]: %v", rel.TagName, err)
} }