Remove RenderEmojiPlain from template helper (#29375)
RenderEmojiPlain(emoji.ReplaceAliases) should be called explicitly for some contents, but not for everything. Actually in modern days, in most cases it doesn't need such "ReplaceAliases". So only keep it for issue/PR titles. If anyone really needs to do ReplaceAliases for some contents, I will propose a following fix. (cherry picked from commit 10c7996b5a5c705964fc6cc9c1817eea1fc436ef) Conflicts: templates/base/head.tmpl context
This commit is contained in:
		
							parent
							
								
									757567d3bd
								
							
						
					
					
						commit
						f92c3de965
					
				
					 6 changed files with 10 additions and 20 deletions
				
			
		| 
						 | 
				
			
			@ -11,8 +11,8 @@
 | 
			
		|||
			<div class="ui attached segment">
 | 
			
		||||
				<div class="ui two column grid">
 | 
			
		||||
					<div class="column left aligned">
 | 
			
		||||
						<strong>{{.Name | RenderEmojiPlain}}</strong>
 | 
			
		||||
						<br>{{.About | RenderEmojiPlain}}
 | 
			
		||||
						<strong>{{.Name}}</strong>
 | 
			
		||||
						<br>{{.About}}
 | 
			
		||||
					</div>
 | 
			
		||||
					<div class="column right aligned">
 | 
			
		||||
						<a href="{{$.RepoLink}}/issues/new?template={{.FileName}}{{if $.milestone}}&milestone={{$.milestone}}{{end}}{{if $.project}}&project={{$.project}}{{end}}" class="ui primary button">{{ctx.Locale.Tr "repo.issues.choose.get_started"}}</a>
 | 
			
		||||
| 
						 | 
				
			
			@ -24,8 +24,8 @@
 | 
			
		|||
			<div class="ui attached segment">
 | 
			
		||||
				<div class="ui two column grid">
 | 
			
		||||
					<div class="column left aligned">
 | 
			
		||||
						<strong>{{.Name | RenderEmojiPlain}}</strong>
 | 
			
		||||
						<br>{{.About | RenderEmojiPlain}}
 | 
			
		||||
						<strong>{{.Name}}</strong>
 | 
			
		||||
						<br>{{.About}}
 | 
			
		||||
					</div>
 | 
			
		||||
					<div class="column right aligned">
 | 
			
		||||
						<a href="{{.URL}}" class="ui primary button">{{svg "octicon-link-external"}} {{ctx.Locale.Tr "repo.issues.choose.open_external_link"}}</a>
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue