From fc8799f26929fc6a6fb659415615087bc2152935 Mon Sep 17 00:00:00 2001
From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Tue, 12 Mar 2024 18:53:53 +0800
Subject: [PATCH] Use Get but not Post to get actions artifacts (#29734)
(cherry picked from commit 171d3d9a3c891d107001094b9118d93b0b00c02c)
Conflicts:
routers/web/web.go
---
routers/web/web.go | 2 +-
web_src/js/components/RepoActionView.vue | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/routers/web/web.go b/routers/web/web.go
index 114a50cf08..2e42d7d63b 100644
--- a/routers/web/web.go
+++ b/routers/web/web.go
@@ -1413,7 +1413,7 @@ func registerRoutes(m *web.Route) {
})
m.Post("/cancel", reqRepoActionsWriter, actions.Cancel)
m.Post("/approve", reqRepoActionsWriter, actions.Approve)
- m.Post("/artifacts", actions.ArtifactsView)
+ m.Get("/artifacts", actions.ArtifactsView)
m.Get("/artifacts/{artifact_name}", actions.ArtifactsDownloadView)
m.Delete("/artifacts/{artifact_name}", reqRepoActionsWriter, actions.ArtifactsDeleteView)
m.Post("/rerun", reqRepoActionsWriter, actions.Rerun)
diff --git a/web_src/js/components/RepoActionView.vue b/web_src/js/components/RepoActionView.vue
index 83a10d3fea..0f66e53c54 100644
--- a/web_src/js/components/RepoActionView.vue
+++ b/web_src/js/components/RepoActionView.vue
@@ -5,7 +5,7 @@ import {createApp} from 'vue';
import {toggleElem} from '../utils/dom.js';
import {formatDatetime} from '../utils/time.js';
import {renderAnsi} from '../render/ansi.js';
-import {POST, DELETE} from '../modules/fetch.js';
+import {GET, POST, DELETE} from '../modules/fetch.js';
const sfc = {
name: 'RepoActionView',
@@ -199,7 +199,7 @@ const sfc = {
},
async fetchArtifacts() {
- const resp = await POST(`${this.actionsURL}/runs/${this.runIndex}/artifacts`);
+ const resp = await GET(`${this.actionsURL}/runs/${this.runIndex}/artifacts`);
return await resp.json();
},