1
0
Fork 0
forgejo/modules
Lunny Xiao 6433ba0ec3
Move macaron to chi (#14293)
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR.

- [x] Define `context.ResponseWriter` interface with an implementation `context.Response`.
- [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before.
- [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic .
- [x] Use https://github.com/unrolled/render instead of macaron's internal render
- [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip
- [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK**
- [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha
- [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache
- [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding
- [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors
- [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation`
- [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle.
- [x] Removed macaron log service because it's not need any more. **BREAK**
- [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition.
- [x] Move Git HTTP protocol implementation to use routers directly.
- [x] Fix the problem that chi routes don't support trailing slash but macaron did.
- [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. 

Notices:
- Chi router don't support request with trailing slash
- Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI.

Co-authored-by: 6543 <6543@obermui.de>
2021-01-26 16:36:53 +01:00
..
analyze
auth Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
avatar Avatars and Repo avatars support storing in minio (#12516) 2020-10-14 21:07:51 +08:00
base Kd/fix allow svg doctype (#14344) 2021-01-15 17:38:41 +08:00
cache Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
charset Ensure that the detected charset order is set in chardet test (#12574) 2020-08-23 14:15:29 +01:00
context Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
convert Display current stopwatch in navbar (#14122) 2021-01-21 15:51:52 +01:00
cron Added option to disable migrations (#13114) 2020-12-21 15:39:41 +01:00
doctor Refactor doctor (#12264) 2020-12-02 06:56:04 +02:00
emoji Fix emoji detection in certain cases (#12320) 2020-07-25 16:40:04 +03:00
eventsource
forms Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
generate
git Add pager to the branches page (#14202) 2021-01-19 05:07:38 +01:00
gitgraph [Refactor] CombinedStatus and CommitStatus related functions & structs (#14026) 2020-12-18 11:33:32 +08:00
graceful Fix windows build error (#14263) 2021-01-06 09:38:00 +08:00
hcaptcha hCaptcha Support (#12594) 2020-10-02 23:37:53 -04:00
highlight Use existing analyzer module for language detection for highlighting (#13522) 2020-11-13 16:13:41 -05:00
httpcache Use IsProd instead of testing if it's equal. (#14336) 2021-01-14 23:17:03 +02:00
httplib
indexer Upgrade blevesearch dependency to v2.0.1 (#14346) 2021-01-17 20:21:14 -05:00
lfs Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
log Fix windows build error (#14263) 2021-01-06 09:38:00 +08:00
markup Prevent panic on fuzzer provided string (#14405) 2021-01-20 23:10:50 +08:00
matchlist Add Allow-/Block-List for Migrate & Mirrors (#13610) 2020-11-28 19:37:58 -05:00
metrics
middlewares Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
migrations Add support to migrate from gogs (#14342) 2021-01-21 20:33:58 +01:00
nosql Allow common redis and leveldb connections (#12385) 2020-09-28 00:09:46 +03:00
notification Send notifications for mentions in pulls, issues, (code-)comments (#14218) 2021-01-02 18:04:02 +01:00
options Add StatDir and replace com.StatDir (#14099) 2020-12-22 07:40:57 +08:00
password Check passwords against HaveIBeenPwned (#12716) 2020-09-08 17:06:39 -05:00
pprof
private Fix send mail (#13312) 2020-10-26 12:42:27 -04:00
process
public When visit /favicon.ico but the static file is not exist return 404 but not continue to handle the route (#14211) 2021-01-01 17:05:45 -05:00
queue Slightly simplify the queue settings code to help reduce the risk of problems (#12976) 2020-10-15 17:40:03 -04:00
recaptcha hCaptcha Support (#12594) 2020-10-02 23:37:53 -04:00
references Add mentionable teams to tributeValues and change team mention rules to gh's style (#13198) 2020-12-21 16:39:28 +01:00
repofiles Standardize Co-Authored-By / Reviewed-By strings (#14097) 2020-12-21 21:19:33 -05:00
repository Check if label template exist first (#14384) 2021-01-18 21:00:50 +01:00
secret Attachments: Add extension support, allow all types for releases (#12465) 2020-10-05 01:49:33 -04:00
session Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
setting Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
ssh migrate from com.* to alternatives (#14103) 2020-12-25 11:59:32 +02:00
storage Fix Storage mapping (#13297) 2020-10-25 17:19:06 +00:00
structs Add support to migrate from gogs (#14342) 2021-01-21 20:33:58 +01:00
svg Fix filepath basename on Windows for SVG bindata (#12241) 2020-07-13 21:16:40 +01:00
sync
task Migrations: Use Process Manager to create own Context (#13792) 2020-12-02 18:36:06 +00:00
templates Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
test Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
timeutil Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
translation Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
upload Update golangci-lint to version 1.31.0 (#13102) 2020-10-11 21:27:20 +01:00
uri Dump github/gitlab/gitea repository data to a local directory and restore to gitea (#12244) 2020-12-27 11:34:19 +08:00
user
util migrate from com.* to alternatives (#14103) 2020-12-25 11:59:32 +02:00
validation Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00
web Move macaron to chi (#14293) 2021-01-26 16:36:53 +01:00