1
0
Fork 0
forgejo/templates
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
admin Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
code Fix 500 error of searching commits (#28576) 2023-12-21 23:09:14 +00:00
custom [FEAT] Repository flags 2024-02-05 16:09:42 +01:00
devtest Improve CSS helper naming (#28769) 2024-01-12 20:28:01 +08:00
explore Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
mail [GITEA] notifies admins on new user registration 2024-02-05 16:09:28 +01:00
org [MODERATION] User blocking 2024-02-05 15:56:45 +01:00
package Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
projects Use full width for project boards (#28225) 2023-11-27 17:43:52 +00:00
repo [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
shared Merge branch 'rebase-forgejo-branding' into wip-forgejo 2024-02-05 18:58:18 +01:00
status [GITEA] Improve 404 screen on mobile 2024-02-05 16:09:42 +01:00
swagger Add merge style fast-forward-only (#28954) 2024-02-14 17:19:19 +01:00
user Merge branch 'rebase-forgejo-dependency' into wip-forgejo 2024-02-05 18:58:23 +01:00
webhook [BRANDING] add the forgejo webhook type & update webhook docs URLs 2024-02-05 16:02:14 +01:00
home.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
install.tmpl Merge branch 'rebase-forgejo-branding' into wip-forgejo 2024-02-05 18:58:18 +01:00
post-install.tmpl [BRANDING] Custom loading animation for Forgejo 2024-02-05 16:02:13 +01:00