85505e0f81
- Motivation for this PR is that I'd noticed that a lot of repeated
calls are happening between the test functions and that certain tests
weren't using helper functions like `GetCSRF`, therefor this refactor of
the integration tests to keep it: clean, small and hopefully more
maintainable and understandable.
- There are now three integration tests: `TestBlockUser`,
`TestBlockUserFromOrganization` and `TestBlockActions` (and has been
moved in that order in the source code).
- `TestBlockUser` is for doing blocking related actions as an user and
`TestBlockUserFromOrganization` as an organisation, even though they
execute the same kind of tests they do not share any database calls or
logic and therefor it currently doesn't make sense to merge them
together (hopefully such oppurtinutiy might be presented in the future).
- `TestBlockActions` now contain all tests for actions that should be
blocked after blocking has happened, most tests now share the same doer
and blocked users and a extra fixture has been added to make this
possible for the comment test.
- Less code, more comments and more re-use between tests.
(cherry picked from commit ffb393213d)
77 lines
1.4 KiB
YAML
77 lines
1.4 KiB
YAML
-
|
|
id: 1
|
|
type: 7 # label
|
|
poster_id: 2
|
|
issue_id: 1 # in repo_id 1
|
|
label_id: 1
|
|
content: "1"
|
|
created_unix: 946684810
|
|
-
|
|
id: 2
|
|
type: 0 # comment
|
|
poster_id: 3 # user not watching (see watch.yml)
|
|
issue_id: 1 # in repo_id 1
|
|
content: "good work!"
|
|
created_unix: 946684811
|
|
updated_unix: 946684811
|
|
-
|
|
id: 3
|
|
type: 0 # comment
|
|
poster_id: 5 # user not watching (see watch.yml)
|
|
issue_id: 1 # in repo_id 1
|
|
content: "meh..."
|
|
created_unix: 946684812
|
|
updated_unix: 946684812
|
|
-
|
|
id: 4
|
|
type: 21 # code comment
|
|
poster_id: 1
|
|
issue_id: 2
|
|
content: "meh..."
|
|
review_id: 4
|
|
line: 4
|
|
tree_path: "README.md"
|
|
created_unix: 946684812
|
|
invalidated: false
|
|
-
|
|
id: 5
|
|
type: 21 # code comment
|
|
poster_id: 1
|
|
issue_id: 2
|
|
content: "meh..."
|
|
line: -4
|
|
tree_path: "README.md"
|
|
created_unix: 946684812
|
|
invalidated: false
|
|
|
|
-
|
|
id: 6
|
|
type: 21 # code comment
|
|
poster_id: 1
|
|
issue_id: 2
|
|
content: "it's already invalidated. boring..."
|
|
line: -4
|
|
tree_path: "README.md"
|
|
created_unix: 946684812
|
|
invalidated: true
|
|
|
|
-
|
|
id: 7
|
|
type: 21 # code comment
|
|
poster_id: 100
|
|
issue_id: 3
|
|
content: "a review from a deleted user"
|
|
line: -4
|
|
review_id: 10
|
|
tree_path: "README.md"
|
|
created_unix: 946684812
|
|
invalidated: true
|
|
|
|
-
|
|
id: 8
|
|
type: 0 # comment
|
|
poster_id: 2
|
|
issue_id: 4 # in repo_id 2
|
|
content: "I just wanted to add.."
|
|
created_unix: 946684812
|
|
updated_unix: 946684812
|