1
0
Fork 0
forgejo/services/convert
Jimmy Praet 5d3fdd1212
Add branch protection setting for ignoring stale approvals (#28498)
Fixes #27114.

* In Gitea 1.12 (#9532), a "dismiss stale approvals" branch protection
setting was introduced, for ignoring stale reviews when verifying the
approval count of a pull request.
* In Gitea 1.14 (#12674), the "dismiss review" feature was added.
* This caused confusion with users (#25858), as "dismiss" now means 2
different things.
* In Gitea 1.20 (#25882), the behavior of the "dismiss stale approvals"
branch protection was modified to actually dismiss the stale review.

For some users this new behavior of dismissing the stale reviews is not
desirable.

So this PR reintroduces the old behavior as a new "ignore stale
approvals" branch protection setting.

---------

Co-authored-by: delvh <dev.lh@web.de>
2024-01-15 07:20:01 +00:00
..
activity.go For API attachments, use API URL (#25639) 2023-07-10 09:31:19 +00:00
attachment.go Fix attachment download bug (#27486) 2023-10-10 15:33:56 +00:00
convert.go Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
git_commit.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
git_commit_test.go Adjust object format interface (#28469) 2023-12-17 11:56:08 +00:00
issue.go Final round of db.DefaultContext refactor (#27587) 2023-10-14 08:37:24 +00:00
issue_comment.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_test.go
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
mirror.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
notification.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
package.go Fix package webhook (#27839) 2023-10-31 04:43:38 +00:00
pull.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
pull_review.go Fix convert.ToTeams on empty input (#28426) 2024-01-11 22:12:08 +00:00
pull_test.go
release.go add Upload URL to release API (#26663) 2023-08-24 10:36:10 +00:00
release_test.go add Upload URL to release API (#26663) 2023-08-24 10:36:10 +00:00
repository.go Move more functions to db.Find (#28419) 2024-01-15 02:19:25 +00:00
secret.go feat: implement organization secret creation API (#26566) 2023-08-22 11:20:34 +08:00
status.go refactor improve NoBetterThan (#26126) 2023-07-26 08:52:07 +00:00
user.go Fix API leaking Usermail if not logged in (#25097) 2023-07-31 01:18:38 +00:00
user_test.go
utils.go
utils_test.go
wiki.go