1
0
Fork 0
forgejo/modules/git
zeripath 3d8b5ad5f3
Fix a couple of CommentAsPatch issues. (#14804)
* CutDiffAroundLine makes the incorrect assumption that `---` and `+++` always represent part of the header of a diff.

This PR adds a flag to its parsing to prevent this problem and adds a streaming parsing technique to CutDiffAroundLine using an io.pipe instead of just sending data to an unbounded buffer.

Fix #14711

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Handle unquoted comment patch files

When making comment patches unfortunately the patch does not always quote the filename
This makes the diff --git header ambiguous again.

This PR finally adds handling for ambiguity in to parse patch

Fix #14812

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Add in testing for no error

There is no way currently for CutDiffAroundLine in this test to cause an
error however, it should still be tested.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-02-27 19:46:14 +01:00
..
pipeline Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tests/repos
batch_reader_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
blame.go Prevent panic on git blame by limiting lines to 4096 bytes at most (#13470) 2020-11-09 21:14:02 -05:00
blame_test.go
blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
blob_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
blob_nogogit.go Remove spurious DataAsync Error logging (#14599) 2021-02-07 21:04:58 +00:00
blob_test.go
command.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
command_test.go
commit.go HasPreviousCommit causes recursive load of commits unnecessarily (#14598) 2021-02-10 07:00:57 +00:00
commit_archive.go
commit_convert_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info_test.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_reader.go Fix bug in commit verification introduced in #13673 (#14040) 2020-12-17 21:42:33 +01:00
commit_test.go HasPreviousCommit causes recursive load of commits unnecessarily (#14598) 2021-02-10 07:00:57 +00:00
diff.go Fix a couple of CommentAsPatch issues. (#14804) 2021-02-27 19:46:14 +01:00
diff_test.go Fix a couple of CommentAsPatch issues. (#14804) 2021-02-27 19:46:14 +01:00
error.go
git.go Migrations: Use Process Manager to create own Context (#13792) 2020-12-02 18:36:06 +00:00
git_test.go
hook.go Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186) 2020-11-27 21:42:08 -05:00
last_commit_cache.go Ensure memcache TTL cannot be over 30 days (#14592) 2021-02-09 22:29:03 +00:00
last_commit_cache_gogit.go Ensure memcache TTL cannot be over 30 days (#14592) 2021-02-09 22:29:03 +00:00
last_commit_cache_nogogit.go Ensure memcache TTL cannot be over 30 days (#14592) 2021-02-09 22:29:03 +00:00
notes.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
notes_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
notes_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
notes_test.go
parse_gogit.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
parse_gogit_test.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
parse_nogogit.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
parse_nogogit_test.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
README.md
ref.go Multiple GitGraph improvements: Exclude PR heads, Add branch/PR links, Show only certain branches, (#12766) 2020-11-08 12:21:54 -05:00
repo.go migrate from com.* to alternatives (#14103) 2020-12-25 11:59:32 +02:00
repo_attribute.go go-version constraints ignore pre-releases (#13234) 2020-10-21 11:42:08 -04:00
repo_base_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_base_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blame.go
repo_blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blob_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blob_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blob_test.go
repo_branch.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_branch_gogit.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_branch_nogogit.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_branch_test.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_commit.go Do not assume all 40 char strings are SHA1s (#14624) 2021-02-10 07:37:25 +00:00
repo_commit_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_commit_nogogit.go Fix when a commit not found returned 500 (#14732) 2021-02-18 19:40:17 -05:00
repo_commit_test.go
repo_commitgraph_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_compare.go Restore detection of branches are equal on compare page (#14586) 2021-02-16 16:39:45 +01:00
repo_compare_test.go
repo_gpg.go
repo_hook.go
repo_index.go
repo_language_stats.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_language_stats_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_language_stats_nogogit.go Use cat-file --batch in GetLanguageStats (#14685) 2021-02-17 14:32:47 -05:00
repo_object.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_test.go
repo_stats.go refactor repo_stats to use os.pipe (#11726) 2020-09-05 16:12:14 -04:00
repo_stats_test.go
repo_tag.go Refactor get tag to remove unnecessary steps (#14058) 2020-12-20 00:30:39 +02:00
repo_tag_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_tag_nogogit.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_tag_test.go
repo_test.go
repo_tree.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_tree_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_tree_nogogit.go Fix git.parseTagData (#14105) 2020-12-22 21:44:25 +01:00
sha1.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
sha1_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
sha1_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
submodule.go Compare SSH_DOMAIN when parsing submodule URLs (#12753) 2020-09-07 20:08:10 -04:00
submodule_test.go Compare SSH_DOMAIN when parsing submodule URLs (#12753) 2020-09-07 20:08:10 -04:00
tag.go Fix git.parseTagData (#14105) 2020-12-22 21:44:25 +01:00
tag_test.go Fix git.parseTagData (#14105) 2020-12-22 21:44:25 +01:00
tree.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_blob_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_blob_nogogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_entry.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_entry_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_entry_mode.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_entry_nogogit.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
tree_entry_test.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_gogit.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_nogogit.go Reduce calls to git cat-file -s (#14682) 2021-02-17 22:32:25 +01:00
utils.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
utils_test.go

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.