9fa6bdb64e
* Add Cache-Control to avatar redirects This does seem to do the trick to make the Avatar redirects cachable in Chrome. In Firefox, it does not seem to work, thought and I found no way to suppress the requests to the original URLs, I even tried setting an Etag to no avail. Related discussion in https://github.com/go-gitea/gitea/issues/16964. Co-authored-by: zeripath <art27@cantab.net>
104 lines
2.6 KiB
Go
104 lines
2.6 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package user
|
|
|
|
import (
|
|
"errors"
|
|
"net/url"
|
|
"path"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/httpcache"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
)
|
|
|
|
func cacheableRedirect(ctx *context.Context, location string) {
|
|
ctx.Resp.Header().Set("Cache-Control", httpcache.GetCacheControl())
|
|
ctx.Redirect(location)
|
|
}
|
|
|
|
// Avatar redirect browser to user avatar of requested size
|
|
func Avatar(ctx *context.Context) {
|
|
userName := ctx.Params(":username")
|
|
size, err := strconv.Atoi(ctx.Params(":size"))
|
|
if err != nil {
|
|
ctx.ServerError("Invalid avatar size", err)
|
|
return
|
|
}
|
|
|
|
log.Debug("Asked avatar for user %v and size %v", userName, size)
|
|
|
|
var user *models.User
|
|
if strings.ToLower(userName) != "ghost" {
|
|
user, err = models.GetUserByName(userName)
|
|
if err != nil {
|
|
if models.IsErrUserNotExist(err) {
|
|
ctx.ServerError("Requested avatar for invalid user", err)
|
|
} else {
|
|
ctx.ServerError("Retrieving user by name", err)
|
|
}
|
|
return
|
|
}
|
|
} else {
|
|
user = models.NewGhostUser()
|
|
}
|
|
|
|
cacheableRedirect(ctx, user.RealSizedAvatarLink(size))
|
|
}
|
|
|
|
// AvatarByEmailHash redirects the browser to the appropriate Avatar link
|
|
func AvatarByEmailHash(ctx *context.Context) {
|
|
var err error
|
|
|
|
hash := ctx.Params(":hash")
|
|
if len(hash) == 0 {
|
|
ctx.ServerError("invalid avatar hash", errors.New("hash cannot be empty"))
|
|
return
|
|
}
|
|
|
|
var email string
|
|
email, err = models.GetEmailForHash(hash)
|
|
if err != nil {
|
|
ctx.ServerError("invalid avatar hash", err)
|
|
return
|
|
}
|
|
if len(email) == 0 {
|
|
cacheableRedirect(ctx, models.DefaultAvatarLink())
|
|
return
|
|
}
|
|
size := ctx.FormInt("size")
|
|
if size == 0 {
|
|
size = models.DefaultAvatarSize
|
|
}
|
|
|
|
var avatarURL *url.URL
|
|
|
|
if setting.EnableFederatedAvatar && setting.LibravatarService != nil {
|
|
avatarURL, err = models.LibravatarURL(email)
|
|
if err != nil {
|
|
avatarURL, err = url.Parse(models.DefaultAvatarLink())
|
|
if err != nil {
|
|
ctx.ServerError("invalid default avatar url", err)
|
|
return
|
|
}
|
|
}
|
|
} else if !setting.DisableGravatar {
|
|
copyOfGravatarSourceURL := *setting.GravatarSourceURL
|
|
avatarURL = ©OfGravatarSourceURL
|
|
avatarURL.Path = path.Join(avatarURL.Path, hash)
|
|
} else {
|
|
avatarURL, err = url.Parse(models.DefaultAvatarLink())
|
|
if err != nil {
|
|
ctx.ServerError("invalid default avatar url", err)
|
|
return
|
|
}
|
|
}
|
|
|
|
cacheableRedirect(ctx, models.MakeFinalAvatarURL(avatarURL, size))
|
|
}
|