1
0
Fork 0
forgejo/cmd
Lunny Xiao 4eb2a29910
Improve ObjectFormat interface (#28496)
The 4 functions are duplicated, especially as interface methods. I think
we just need to keep `MustID` the only one and remove other 3.

```
MustID(b []byte) ObjectID
MustIDFromString(s string) ObjectID
NewID(b []byte) (ObjectID, error)
NewIDFromString(s string) (ObjectID, error)
```

Introduced the new interfrace method `ComputeHash` which will replace
the interface `HasherInterface`. Now we don't need to keep two
interfaces.

Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new
function will detect the hash length to decide which objectformat of it.
If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be
right if the commitID is a full one. So the parameter should be always a
full commit id.

@AdamMajer Please review.
2023-12-19 07:20:47 +00:00
..
actions.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
admin.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
admin_auth.go Use db.Find instead of writing methods for every object (#28084) 2023-11-24 03:49:41 +00:00
admin_auth_ldap.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_ldap_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_oauth.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_auth_stmp.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
admin_regenerate.go move the gitea admin subcommands into separate files (#27307) 2023-09-27 12:25:38 +00:00
admin_user.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_change_password.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_create.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
admin_user_delete.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
admin_user_generate_access_token.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
admin_user_list.go Reduce usage of db.DefaultContext (#27073) 2023-09-14 17:09:32 +00:00
admin_user_must_change_password.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
cert.go Expanded minimum RSA Keylength to 3072 (#26604) 2023-08-28 00:53:16 +00:00
cmd.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
docs.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
doctor.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
doctor_convert.go Improve "gitea doctor" sub-command and fix "help" commands (#26072) 2023-07-25 14:38:27 +00:00
doctor_test.go Improve doctor cli behavior (#28422) 2023-12-11 15:55:10 +00:00
dump.go fixed duplicate attachments on dump on windows (#28019) 2023-11-14 02:15:45 +01:00
dump_repo.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
embedded.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
generate.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
hook.go Improve ObjectFormat interface (#28496) 2023-12-19 07:20:47 +00:00
hook_test.go Refactor internal API for git commands, use meaningful messages instead of "Internal Server Error" (#23687) 2023-03-29 14:32:26 +08:00
keys.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
mailer.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
main.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
manager.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
manager_logging.go Add missing default value for some Bool cli flags (#26082) 2023-07-24 06:49:18 +00:00
migrate.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
migrate_storage.go fix: typo (#27009) 2023-09-11 09:30:18 +00:00
migrate_storage_test.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
restore_repo.go Refactor to use urfave/cli/v2 (#25959) 2023-07-21 17:28:19 +08:00
serv.go Improve CLI code and descriptions (#28482) 2023-12-15 15:49:01 +00:00
web.go Refactor tests (#26464) 2023-08-12 16:30:16 +00:00
web_acme.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web_graceful.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
web_https.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00