65248945c9
Clarify when "string" should be used (and be escaped), and when "template.HTML" should be used (no need to escape) And help PRs like #29059 , to render the error messages correctly. (cherry picked from commit f3eb835886031df7a562abc123c3f6011c81eca8) Conflicts: modules/web/middleware/binding.go routers/web/feed/convert.go tests/integration/branches_test.go tests/integration/repo_branch_test.go trivial context conflicts
137 lines
4.2 KiB
Go
137 lines
4.2 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package i18n
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestLocaleStore(t *testing.T) {
|
|
testData1 := []byte(`
|
|
.dot.name = Dot Name
|
|
fmt = %[1]s %[2]s
|
|
|
|
[section]
|
|
sub = Sub String
|
|
mixed = test value; <span style="color: red\; background: none;">%s</span>
|
|
`)
|
|
|
|
testData2 := []byte(`
|
|
fmt = %[2]s %[1]s
|
|
|
|
[section]
|
|
sub = Changed Sub String
|
|
`)
|
|
|
|
ls := NewLocaleStore()
|
|
assert.NoError(t, ls.AddLocaleByIni("lang1", "Lang1", testData1, nil))
|
|
assert.NoError(t, ls.AddLocaleByIni("lang2", "Lang2", testData2, nil))
|
|
ls.SetDefaultLang("lang1")
|
|
|
|
lang1, _ := ls.Locale("lang1")
|
|
lang2, _ := ls.Locale("lang2")
|
|
|
|
result := lang1.TrString("fmt", "a", "b")
|
|
assert.Equal(t, "a b", result)
|
|
|
|
result = lang2.TrString("fmt", "a", "b")
|
|
assert.Equal(t, "b a", result)
|
|
|
|
result = lang1.TrString("section.sub")
|
|
assert.Equal(t, "Sub String", result)
|
|
|
|
result = lang2.TrString("section.sub")
|
|
assert.Equal(t, "Changed Sub String", result)
|
|
|
|
langNone, _ := ls.Locale("none")
|
|
result = langNone.TrString(".dot.name")
|
|
assert.Equal(t, "Dot Name", result)
|
|
|
|
result2 := lang2.TrHTML("section.mixed", "a&b")
|
|
assert.EqualValues(t, `test value; <span style="color: red; background: none;">a&b</span>`, result2)
|
|
|
|
langs, descs := ls.ListLangNameDesc()
|
|
assert.ElementsMatch(t, []string{"lang1", "lang2"}, langs)
|
|
assert.ElementsMatch(t, []string{"Lang1", "Lang2"}, descs)
|
|
|
|
found := lang1.HasKey("no-such")
|
|
assert.False(t, found)
|
|
assert.NoError(t, ls.Close())
|
|
}
|
|
|
|
func TestLocaleStoreMoreSource(t *testing.T) {
|
|
testData1 := []byte(`
|
|
a=11
|
|
b=12
|
|
`)
|
|
|
|
testData2 := []byte(`
|
|
b=21
|
|
c=22
|
|
`)
|
|
|
|
ls := NewLocaleStore()
|
|
assert.NoError(t, ls.AddLocaleByIni("lang1", "Lang1", testData1, testData2))
|
|
lang1, _ := ls.Locale("lang1")
|
|
assert.Equal(t, "11", lang1.TrString("a"))
|
|
assert.Equal(t, "21", lang1.TrString("b"))
|
|
assert.Equal(t, "22", lang1.TrString("c"))
|
|
}
|
|
|
|
func TestLocaleStoreQuirks(t *testing.T) {
|
|
const nl = "\n"
|
|
q := func(q1, s string, q2 ...string) string {
|
|
return q1 + s + strings.Join(q2, "")
|
|
}
|
|
testDataList := []struct {
|
|
in string
|
|
out string
|
|
hint string
|
|
}{
|
|
{` xx`, `xx`, "simple, no quote"},
|
|
{`" xx"`, ` xx`, "simple, double-quote"},
|
|
{`' xx'`, ` xx`, "simple, single-quote"},
|
|
{"` xx`", ` xx`, "simple, back-quote"},
|
|
|
|
{`x\"y`, `x\"y`, "no unescape, simple"},
|
|
{q(`"`, `x\"y`, `"`), `"x\"y"`, "unescape, double-quote"},
|
|
{q(`'`, `x\"y`, `'`), `x\"y`, "no unescape, single-quote"},
|
|
{q("`", `x\"y`, "`"), `x\"y`, "no unescape, back-quote"},
|
|
|
|
{q(`"`, `x\"y`) + nl + "b=", `"x\"y`, "half open, double-quote"},
|
|
{q(`'`, `x\"y`) + nl + "b=", `'x\"y`, "half open, single-quote"},
|
|
{q("`", `x\"y`) + nl + "b=`", `x\"y` + nl + "b=", "half open, back-quote, multi-line"},
|
|
|
|
{`x ; y`, `x ; y`, "inline comment (;)"},
|
|
{`x # y`, `x # y`, "inline comment (#)"},
|
|
{`x \; y`, `x ; y`, `inline comment (\;)`},
|
|
{`x \# y`, `x # y`, `inline comment (\#)`},
|
|
}
|
|
|
|
for _, testData := range testDataList {
|
|
ls := NewLocaleStore()
|
|
err := ls.AddLocaleByIni("lang1", "Lang1", []byte("a="+testData.in), nil)
|
|
lang1, _ := ls.Locale("lang1")
|
|
assert.NoError(t, err, testData.hint)
|
|
assert.Equal(t, testData.out, lang1.TrString("a"), testData.hint)
|
|
assert.NoError(t, ls.Close())
|
|
}
|
|
|
|
// TODO: Crowdin needs the strings to be quoted correctly and doesn't like incomplete quotes
|
|
// and Crowdin always outputs quoted strings if there are quotes in the strings.
|
|
// So, Gitea's `key="quoted" unquoted` content shouldn't be used on Crowdin directly,
|
|
// it should be converted to `key="\"quoted\" unquoted"` first.
|
|
// TODO: We can not use UnescapeValueDoubleQuotes=true, because there are a lot of back-quotes in en-US.ini,
|
|
// then Crowdin will output:
|
|
// > key = "`x \" y`"
|
|
// Then Gitea will read a string with back-quotes, which is incorrect.
|
|
// TODO: Crowdin might generate multi-line strings, quoted by double-quote, it's not supported by LocaleStore
|
|
// LocaleStore uses back-quote for multi-line strings, it's not supported by Crowdin.
|
|
// TODO: Crowdin doesn't support back-quote as string quoter, it mainly uses double-quote
|
|
// so, the following line will be parsed as: value="`first", comment="second`" on Crowdin
|
|
// > a = `first; second`
|
|
}
|