1
0
Fork 0
forgejo/modules
zeripath c58bc4bf80
Prevent timer leaks in Workerpool and others (#11333)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-08 16:46:05 +01:00
..
analyze Migrate to go-enry new version (#10906) 2020-04-15 20:40:39 +03:00
auth Add option to increase provided OAuth2 token maximum size (#11180) 2020-04-23 00:47:23 +02:00
avatar Improve handling of non-square avatars (#7025) 2019-05-25 14:46:14 +03:00
base Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
cache make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
charset deps: update and fix chardet import (#9351) 2019-12-14 02:15:48 +02:00
context api.Context.NotFound(...) should tolerate nil (#11288) 2020-05-05 21:52:13 +03:00
convert API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
cron Refactor repository check and sync functions (#9854) 2020-01-20 20:01:19 +00:00
emoji Support unicode emojis and remove emojify.js (#11032) 2020-04-28 15:05:39 -03:00
eventsource Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
generate Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
git Manage port in submodule refurl (#11305) 2020-05-07 11:25:52 -03:00
gitgraph Move git graph from models to modules/graph (#9027) 2019-11-16 08:47:57 +08:00
graceful Prevent panic during wrappedConn close at hammertime (#11219) 2020-04-26 21:01:06 -03:00
highlight Add a lot of extension to language mappings for syntax highlights (#7741) 2019-08-05 23:48:31 +08:00
httplib Add golangci (#6418) 2019-06-12 15:41:28 -04:00
indexer Log the indexer path on failure (#11172) 2020-04-22 16:16:58 -04:00
lfs Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
log modules/log: remove noop written variables (#10182) 2020-02-07 21:35:30 +01:00
markup Restore checkbox rendering and prevent poor sanitization of spans (#11277) 2020-05-03 17:17:24 -03:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
migrations Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
notification Add NotifySyncPushCommits to indexer notifier (#11309) 2020-05-08 15:58:40 +01:00
options Rename scripts to build and add revive command as a new build tool command (#10942) 2020-04-03 22:29:12 +03:00
password Add password requirement info on error (#9074) 2019-11-19 22:44:58 +00:00
pprof Add golangci (#6418) 2019-06-12 15:41:28 -04:00
private Upgrade golangci-lint to 1.24.0 (#10894) 2020-03-30 21:52:45 +03:00
process Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
public Send 404 immediately for known public requests (#11117) 2020-04-18 22:01:06 +01:00
queue Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
recaptcha fixed reCAPTCHA URL (#9083) 2019-11-22 08:03:45 +00:00
references Accept punctuation after simple+cross repository issue references (#10091) 2020-02-01 18:01:30 +00:00
repofiles Fix GetContents(): Dont't ignore Executables (#11192) 2020-04-24 19:20:22 +03:00
repository Fix forked repo has no icon and language stat. (#10791) 2020-04-08 15:13:04 +03:00
secret Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
session Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
setting Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
ssh log.Fatal on failure to listen to SSH port (#10795) 2020-03-23 07:59:38 +00:00
structs API: Add pull review endpoints (#11224) 2020-05-02 03:20:51 +03:00
sync Fix missing unlock in uniquequeue (#9790) 2020-01-15 23:58:33 +02:00
task Move create/fork repository from models to modules/repository (#9489) 2020-01-12 20:11:17 +08:00
templates Add EventSource support (#11235) 2020-05-07 22:49:00 +01:00
test Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
timeutil Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
upload Fix upload file type check (#7890) 2019-08-17 13:10:17 +03:00
user Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
util Prevent timer leaks in Workerpool and others (#11333) 2020-05-08 16:46:05 +01:00
validation [API] Get a single commit via Ref (#10915) 2020-04-07 22:54:46 -04:00
webhook Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00