1
0
Fork 0
forgejo/templates/repo/diff
KN4CK3R 637451a45e
Rework markup link rendering (#26745)
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-01-15 08:49:24 +00:00
..
blob_excerpt.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
box.tmpl Improve CSS helper naming (#28769) 2024-01-12 20:28:01 +08:00
comment_form.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
comment_form_datahandler.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
comments.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
compare.tmpl Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
conversation.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
csv_diff.tmpl Fix CSV diff for added/deleted files (#21189) 2022-09-17 10:45:32 +08:00
escape_title.tmpl cleanup locale function usage (#27227) 2023-09-24 20:31:58 +00:00
image_diff.tmpl Replace ajax with fetch, improve image diff (#27267) 2023-10-11 12:34:21 +00:00
new_comment.tmpl Do not reload page after adding comments in Pull Request reviews (#13877) 2021-01-08 23:49:55 +02:00
new_review.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
options_dropdown.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
section_code.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
section_split.tmpl Refactor template empty checks (#28351) 2023-12-04 15:48:42 -06:00
section_unified.tmpl Refactor template empty checks (#28351) 2023-12-04 15:48:42 -06:00
stats.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00
whitespace_dropdown.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00