1
0
Fork 0
forgejo/templates/repo/settings/webhook
silverwind e24f651c86
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.

Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.

- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).
2023-06-14 18:17:58 +00:00
..
base.tmpl Change to vertical navbar layout for secondary navbar for repo/user/admin settings (#24246) 2023-04-23 18:21:21 +08:00
base_list.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
delete_modal.tmpl Improve some modal action buttons (#24289) 2023-04-24 07:08:59 -04:00
dingtalk.tmpl
discord.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
feishu.tmpl
gitea.tmpl
gogs.tmpl
history.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
list.tmpl Change to vertical navbar layout for secondary navbar for repo/user/admin settings (#24246) 2023-04-23 18:21:21 +08:00
matrix.tmpl Add Webhook authorization header (#20926) 2022-11-03 20:23:20 +02:00
msteams.tmpl
new.tmpl Fix test delivery button in repo webhook settings page (#24478) 2023-05-02 21:58:18 +02:00
packagist.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
settings.tmpl New webhook trigger for receiving Pull Request review requests (#24481) 2023-05-24 22:06:27 -04:00
slack.tmpl Add template linting via djlint (#25212) 2023-06-14 18:17:58 +00:00
telegram.tmpl
wechatwork.tmpl