1
0
Fork 0
forgejo/web_src/js
Otto Richter 7dc453bb39 Remove inputs in dropdowns from taborder
Inputs are normally present in the taborder of a website. When they are
inside a dropdown, this means a user could theoretically also tab
through them.

With the current dropdown approach, however, this can result in the
focus being trapped, because the dropdown is closed after the focus
switches to the next element.

In this case, the focus moves to the end of the page, breaking keyword
navigation and making parts of the page inaccessible with a keyboard.

I was only able to reproduce this in Firefox.

This patch removes inputs inside dropdowns from taborder. It should be
generally safe even with potential side-effects, because *nothing*
inside dropdowns should be in the tab order.

This is a hotfix for https://codeberg.org/forgejo/forgejo/issues/2635,
but I acknowledge it is not an ideal solution.
2024-03-12 02:24:17 +01:00
..
components Merge pull request '[UI] Actions: Link to Workflow in View' (#1866) from n0toose/forgejo:forgejo-add-workflow-link into forgejo 2024-02-28 17:28:16 +00:00
features Filter Repositories by type (#29231) 2024-03-06 12:10:46 +08:00
markup Remove jQuery from the comment task list (#29170) 2024-02-17 23:24:30 +01:00
modules Remove inputs in dropdowns from taborder 2024-03-12 02:24:17 +01:00
render Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
standalone [FRONTEND] fix javascript linting errors 2024-02-25 23:43:58 +01:00
utils Remove jQuery from the Unicode escape button (#29369) 2024-02-26 22:30:27 +01:00
vendor Vendor jquery.are-you-sure with strict mode fixes (#26901) 2023-09-06 00:02:44 +00:00
webcomponents Fix URL calculation in clone input box (#29470) 2024-03-06 12:10:44 +08:00
bootstrap.js Fix/Improve processWindowErrorEvent (#29407) 2024-03-06 12:10:44 +08:00
bootstrap.test.js Avoid duplicate JS error messages on UI (#28873) 2024-01-21 14:23:08 +00:00
htmx.js Auto-update the system status in admin dashboard (#29163) 2024-02-17 23:24:31 +01:00
index.js Filter Repositories by type (#29231) 2024-03-06 12:10:46 +08:00
jquery.js Upgrade jQuery to 3.5.0, remove jQuery-Migrate, fix deprecations (#11055) 2020-04-18 18:46:29 -04:00
svg.js Artifact deletion in actions ui (#27172) 2024-02-23 09:06:14 +01:00
svg.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
utils.js enforce maxlength in frontend (#29389) 2024-02-26 22:30:27 +01:00
utils.test.js Use vitest globals (#27102) 2023-09-27 04:37:13 +00:00
vitest.setup.js [gitea] Move vitest setup file to root (#29097) 2024-02-10 10:53:43 +01:00