forks/forgejo
1
0
Fork 0
Code Releases Activity
forgejo/modules
History
Eng Zer Jun 8b0aaa5f86
test: use T.TempDir to create temporary test directory (#21043) 
A testing cleanup. 

This pull request replaces `os.MkdirTemp` with `t.TempDir`. We can use the `T.TempDir` function from the `testing` package to create temporary directory. The directory created by `T.TempDir` is automatically removed when the test and all its subtests complete. 

This saves us at least 2 lines (error check, and cleanup) on every instance, or in some cases adds cleanup that we forgot.

Reference: https://pkg.go.dev/testing#T.TempDir

```go
func TestFoo(t *testing.T) {
	// before
	tmpDir, err := os.MkdirTemp("", "")
	require.NoError(t, err)
	defer os.RemoveAll(tmpDir)

	// now
	tmpDir := t.TempDir()
}
```

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2022-09-04 16:14:53 +01:00
..
activitypub Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
analyze
appstate
auth
avatar Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
base
cache
charset Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
container
context Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
convert Fix 500 on time tracking in timeline API (#21052) 2022-09-04 15:01:23 +01:00
csv Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
doctor Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
emoji Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
eventsource Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
generate
git test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
gitgraph
graceful Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00
hcaptcha
highlight Rework file highlight rendering and fix yaml copy-paste (#19967) 2022-07-30 21:17:43 +02:00
hostmatcher Add proxy host into allow list (#20798) 2022-08-16 20:15:54 -04:00
httpcache
httplib
indexer test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
issue/template Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
json
lfs
log test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
markup Kd/ci playwright go test (#20123) 2022-09-02 15:18:23 -04:00
mcaptcha Add support mCaptcha as captcha provider (#20458) 2022-08-10 15:20:10 +02:00
metrics Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
migration Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
mirror
nosql fix broken insecureskipverify handling in rediss connection uris (#20967) 2022-08-29 16:38:49 +02:00
notification Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
options Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
packages Add support for Vagrant packages (#20930) 2022-08-29 15:04:45 +08:00
paginator
password
pprof Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
private Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00
process
proxy
proxyprotocol Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00
public
queue test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
recaptcha
references
regexplru
repository Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
secret
session
setting Only show relevant repositories on explore page (#19361) 2022-08-25 20:38:41 +02:00
sitemap
ssh Support Proxy protocol (#12527) 2022-08-21 19:20:43 +01:00
storage
structs Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
svg
sync
templates Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
test Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
timeutil Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
translation Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
typesniffer Rework raw file http header logic (#20484) 2022-07-29 17:26:55 +02:00
updatechecker
upload
uri
user
util Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
validation Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
watcher Share HTML template renderers and create a watcher framework (#20218) 2022-08-28 10:43:25 +01:00
web refactor webhook *NewPost (#20729) 2022-08-11 17:48:23 +02:00