1
0
Fork 0
forgejo/templates
KN4CK3R 637451a45e
Rework markup link rendering (#26745)
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary> 

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-01-15 08:49:24 +00:00
..
admin Improve CSS helper naming (#28769) 2024-01-12 20:28:01 +08:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base Move the captcha script loader to the template which really needs it (#28718) 2024-01-07 15:41:46 +00:00
code Fix 500 error of searching commits (#28576) 2023-12-21 23:09:14 +00:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
devtest Improve CSS helper naming (#28769) 2024-01-12 20:28:01 +08:00
explore Add links to owner home page in explore (#28341) 2024-01-05 03:34:35 +00:00
mail Update team invitation email link (#26550) 2023-08-31 16:26:13 +00:00
org Fix button size in "attached header right" (#28770) 2024-01-12 14:43:40 +00:00
package Support for grouping RPMs using paths (#26984) 2024-01-12 03:16:05 +00:00
projects Use full width for project boards (#28225) 2023-11-27 17:43:52 +00:00
repo Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
shared Fix tooltip of variable edit button (#28681) 2024-01-03 06:25:19 +00:00
status Clean up template locale usage (#27856) 2023-10-31 22:11:48 +08:00
swagger Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
user Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
webhook Extract common code to new template (#26933) 2023-09-06 10:11:06 +00:00
home.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
install.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
post-install.tmpl Always use ctx.Locale.Tr inside templates (#27231) 2023-09-25 08:56:50 +00:00