forks/forgejo
1
0
Fork 0
Code Releases Activity
forgejo/modules/git
History
zeripath 0faf175694
Fix missing close in WalkGitLog (#17008) 
When the external context is cancelled it is possible for the
GitLogReader to not itself be Closed.

This PR does three things:

1. Instead of adding a plain defer it wraps the `g.Close` in a func as
`g` may change.
2. It adds the missing explicit g.Close - although the defer fix makes
this unnecessary.
3. It passes down the external context as the base context for the
GitLogReader meaning that the cancellation of the external context will
pass down automatically.

Fix #17007

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-10 17:46:12 +08:00
..
pipeline Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tests/repos
batch_reader.go
blame.go
blame_test.go
blob.go
blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
blob_nogogit.go Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) 2021-08-31 08:43:31 +01:00
blob_test.go
command.go
command_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit.go
commit_convert_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info.go
commit_info_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info_test.go
commit_reader.go
commit_test.go
diff.go
diff_test.go
error.go
git.go
git_test.go
hook.go
last_commit_cache.go
last_commit_cache_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
last_commit_cache_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
lfs.go
log_name_status.go Fix missing close in WalkGitLog (#17008) 2021-09-10 17:46:12 +08:00
notes.go
notes_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
notes_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
notes_test.go
parse_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_gogit_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_nogogit_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
README.md
ref.go
remote.go
repo.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_archive.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_attribute.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_attribute_test.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_base_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_base_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blame.go
repo_blob.go
repo_blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blob_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blob_test.go
repo_branch.go
repo_branch_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_branch_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_branch_test.go
repo_commit.go
repo_commit_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_commit_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_commit_test.go
repo_commitgraph_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_compare.go
repo_compare_test.go
repo_gpg.go
repo_hook.go
repo_index.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_language_stats.go
repo_language_stats_gogit.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_language_stats_nogogit.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_object.go
repo_ref.go
repo_ref_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_ref_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_ref_test.go
repo_stats.go
repo_stats_test.go
repo_tag.go
repo_tag_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tag_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tag_test.go
repo_test.go
repo_tree.go
repo_tree_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tree_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
sha1.go
sha1_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
sha1_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
signature.go
signature_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
signature_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
submodule.go
submodule_test.go
tag.go
tag_test.go
tree.go
tree_blob.go
tree_blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_blob_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry.go
tree_entry_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry_mode.go
tree_entry_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
utils.go
utils_test.go

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.