1
0
Fork 0
forgejo/models
zeripath 3fd060eb37
Include OriginalAuthor in Reaction constraint (#13505)
When migrating repositories with reactions with deleted users, the original
author id may be -1. This means that it is possible to end up attempting
to create multiple reactions with the same [ Type, IssueID, CommentID, UserID,
OriginalAuthorID ] thus breaking the constraints.

On SQLite this appears to cause a deadlock but on other dbs this will
cause the migration to fail.

This PR extends the constraint to include the original author username
in the constraint.

Fix #13271

Signed-off-by: Andrew Thornton <art27@cantab.net>
2020-11-10 22:37:11 +00:00
..
fixtures [RFC] Make archival asynchronous (#11296) 2020-11-07 22:27:28 +02:00
migrations Include OriginalAuthor in Reaction constraint (#13505) 2020-11-10 22:37:11 +00:00
access.go
access_test.go
action.go
action_list.go
action_test.go
admin.go
admin_test.go
attachment.go
attachment_test.go
avatar.go
branches.go
branches_test.go
commit_status.go
commit_status_test.go
consistency.go
context.go
convert.go
error.go
error_oauth2.go
external_login_user.go
fixture_generation.go
fixture_test.go
gpg_key.go
gpg_key_test.go
helper.go
helper_directory.go
helper_environment.go
issue.go
issue_assignees.go
issue_assignees_test.go
issue_comment.go Comments on review should have the same sha (#13448) 2020-11-09 01:15:09 -05:00
issue_comment_list.go
issue_comment_test.go
issue_dependency.go
issue_dependency_test.go
issue_label.go
issue_label_test.go
issue_list.go
issue_list_test.go
issue_lock.go
issue_milestone.go
issue_milestone_test.go
issue_reaction.go Include OriginalAuthor in Reaction constraint (#13505) 2020-11-10 22:37:11 +00:00
issue_reaction_test.go
issue_stopwatch.go
issue_stopwatch_test.go
issue_test.go
issue_tracked_time.go
issue_tracked_time_test.go
issue_user.go
issue_user_test.go
issue_watch.go
issue_watch_test.go
issue_xref.go
issue_xref_test.go
lfs.go
lfs_lock.go
list_options.go
log.go Refactor Logger (#13294) 2020-10-31 01:36:46 -04:00
login_source.go
main_test.go
migrate.go
models.go
models_test.go
notification.go
notification_test.go
oauth2.go
oauth2_application.go
oauth2_application_test.go
org.go
org_team.go
org_team_test.go
org_test.go
project.go
project_board.go
project_issue.go
project_test.go
pull.go
pull_list.go
pull_sign.go
pull_test.go
release.go Add the tag list page to the release page (#12096) 2020-11-02 18:10:22 -05:00
repo.go updateSize when create a repo with init commit (#13441) 2020-11-06 23:44:08 -05:00
repo_activity.go
repo_avatar.go
repo_branch.go
repo_collaboration.go
repo_collaboration_test.go
repo_generate.go
repo_generate_test.go
repo_indexer.go
repo_issue.go
repo_language_stats.go
repo_list.go
repo_list_test.go [RFC] Make archival asynchronous (#11296) 2020-11-07 22:27:28 +02:00
repo_mirror.go
repo_permission.go
repo_permission_test.go
repo_redirect.go
repo_redirect_test.go
repo_sign.go
repo_test.go
repo_unit.go
repo_watch.go
repo_watch_test.go
review.go
review_test.go
ssh_key.go don't append key file if asked not to (#13368) 2020-10-31 20:57:41 -04:00
ssh_key_test.go
star.go
star_test.go
task.go
test_fixtures.go
token.go
token_test.go
topic.go
topic_test.go
twofactor.go
u2f.go
u2f_test.go
unit.go
unit_tests.go
update.go
upload.go
user.go
user_avatar.go
user_follow.go
user_follow_test.go
user_heatmap.go
user_heatmap_test.go
user_mail.go
user_mail_test.go
user_openid.go
user_openid_test.go
user_test.go
userlist.go
userlist_test.go
webhook.go
webhook_test.go
wiki.go
wiki_test.go